Created attachment 45259 [details] [review]
patch the warnings

Created attachment 46178 [details] [review]
Alternate patch, uses -Wno-pointer-sign in configure.in instead of casts

*** Bug 169911 has been marked as a duplicate of this bug. ***

Poke... can we get one of these committed? It is breaking my gcc4 tinderbox.

Hrm, also, FWIW, the second patch didn't seem to actually fix my compile
problem. Kjartan's did, however.

Thanks for the patches - it builds on both branches now.
Luis: Since I went with disabling the pointer signedness warnings to avoid the
casting, you have to do a 'make distclean' before rebuilding or you'll get
cached compiler options from automake.

2005-06-10  Martin Wehner  <martin.wehner@gmail.com>

	* eel/eel-labeled-image.c: (labeled_image_get_image_bounds_fill),
	(eel_labeled_image_get_image_bounds),
	(labeled_image_get_label_bounds_fill),
	(eel_labeled_image_get_label_bounds):
	Add default cases with asserts.
	
	* eel/eel-mime-extensions.c: (open_temp_cache_file):
	Initialize filename in error case.

	* eel/eel-open-with-dialog.c: (eel_open_with_dialog_add_icon_idle):
	* eel/eel-preferences.c: (preferences_entry_remove_auto_storage):
	Use NULL instead of 0.

	* configure.in:
	Add --Wno-pointer-sign

	Fix gcc4 compilation (#300646). Based on patches from
	Kjartan Maraas <kmaraas@gnome.org> and
	James M. Cape <jcape@ignore-your.tv>

Martin (and world)- for future reference, the tinderbox does a more
sophisticated version of 'make clean' which looks something like:

rm -rf
cvs up
make

:)