GNOME Bugzilla – Bug 300457
Totem never errors if you try playing a mp3 stream without mp3 plugin
Last modified: 2005-04-14 14:32:19 UTC
Please describe the problem: I tried dragging one of the mp3 url from the Virgin Radio page onto totem. Totems buffers up, then rebuffers, then rebuffers, then rebuffers and so on. I think since I don' t have the GStreamer mp3 plugin installed it fails when its to start playback so instead it just goes back to fill up the buffer again. Steps to reproduce: 1. Go to http://www.virginradio.co.uk/thestation/listen/index.html 2. Drag one of the mp3 url' s onto Totem 3. Watch the buffer fill for as long as you want. Actual results: Expected results: Does this happen every time? Other information:
I can reproduce this; for streams, we should error out if nothing was found in group_commit(), I'm pondering moving the code that is now in change_state() over there alltogether.
Created attachment 45252 [details] [review] patch Does what I said above; is unfortunately partly intermingled with the patch in http://bugzilla.gnome.org/show_bug.cgi?id=172854, because they touch the same code. Errors out correctly for the stream.
Applied.