After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300436 - evolution fails to compile from CVS using pkg-config >= 0.16's pkg.m4
evolution fails to compile from CVS using pkg-config >= 0.16's pkg.m4
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.2.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: JP Rosevear
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-04-13 06:56 UTC by James Henstridge
Modified: 2005-04-20 03:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
evolution-new-pkgconfig.patch (928 bytes, patch)
2005-04-13 09:14 UTC, James Henstridge 		none Details | Review

Description James Henstridge 2005-04-13 06:56:18 UTC 
Please describe the problem:
The PKG_CHECK_MODULES() macro distributed with the new releases of pkg-config is
set up to cache pkg-config results between runs, based on the variable prefix
passed as the first argument.

The EVO_SET_COMPILE_FLAGS() macro always passes "EVOLUTION" as the variable
prefix, which triggers the incorrect return of cached values.

Steps to reproduce:
1. install pkg-config >= 0.16 (the newest release is 0.17.1)
2. check out evolution from CVS and run autogen.sh
3. build evolution

Actual results:
build fails, because the various *_CFLAGS and *_LIBS variables are set wrong.

Expected results:
build succeeds.

Does this happen every time?
yes

Other information:
This problem, and its fix is identical to bug 300435 (filed on
evolution-data-server).  I'll attach a patch shortly (which will be quite
similar to the e-d-s patch).
Comment 1 James Henstridge 2005-04-13 09:14:40 UTC 
Created attachment 45202 [details] [review]
evolution-new-pkgconfig.patch

The equivalent fix for evolution to the one in bug 300435
Comment 2 sobhi 2005-04-19 03:38:42 UTC 
Thanks again James. Got this patch, applied it and solved the compile error. I'm
not familiar with pkg-config, but it seems that this new feature is doing more
harm than good. I recommend that JHBUILD use the older version of pkg-config
until this new feature is removed or fixed. Any ideas?
Comment 3 James Henstridge 2005-04-19 09:19:08 UTC 
JP: does this patch look okay for you?  I can apply it if you think it's okay. 
I am quite confident that the change is correct :)
Comment 4 Rodney Dawes 2005-04-19 16:48:28 UTC 
Looks good. Please commit with appropriate ChangeLog entry.
Comment 5 James Henstridge 2005-04-20 03:42:44 UTC 
checked into the gnome-2-10 and HEAD branches.