After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300076 - [PATCH] Make the keybindings work even when numlock is on
[PATCH] Make the keybindings work even when numlock is on
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-04-10 12:09 UTC by Lukas Lipka
Modified: 2008-02-26 20:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make keybindings work if Numlock is on (2.18 KB, patch)
2005-04-10 12:10 UTC, Lukas Lipka 		none Details | Review

Description Lukas Lipka 2005-04-10 12:09:46 UTC 
The keybindings don't work for me if Numlock is turned on. We fixed this in
Beagle a while ago so I guess it would be nice to backport it to Tomboy as well.
Comment 1 Lukas Lipka 2005-04-10 12:10:40 UTC 
Created attachment 45101 [details] [review]
Make keybindings work if Numlock is on

Please let me know if its ok to commit this.
Comment 2 Alex Graveley 2005-04-27 16:07:06 UTC 
Lukas, why are you calling XGrabKey 32 times??  And why are you ignoring all
those arbitrary modifiers?

Just call XGrabKey with and without GDK_LOCK_MASK in the modifier mask.
Comment 3 Alex Graveley 2005-04-27 16:24:39 UTC 
Okay, it looks like we should be doing the same as
http://mail.gnome.org/archives/gnome-devel-list/2001-February/msg00250.html.  

That is, using AnyModifier in the call to XGrabKey/XUngrabKey and filtering out 

+	ignored_mods = ~(GDK_LOCK_MASK /*capslock*/ | GDK_MOD2_MASK /*numlk*/ | 
+		GDK_MOD5_MASK /*scrolllock*/| 0x2000 /*Xkb modifier*/);

In the KeyPress handler.
Comment 4 Lukas Lipka 2005-04-28 11:44:17 UTC 
Alex it would be better to ask Joe about this. He fixed it like this for us in
Beagle.
Comment 5 Alex Graveley 2005-06-05 21:06:48 UTC 
Just commited a fix for this in CVS.  Please retry, and if you have any
problems, reopen this bug.  Thanks.