GNOME Bugzilla – Bug 272301
Add Marcus Bains line to Evolution
Last modified: 2013-09-10 14:03:47 UTC
Distribution: Debian 3.1 Package: Evolution Priority: Normal Version: GNOME2.8.1 2.0.3 Gnome-Distributor: Debian Synopsis: Add Marcus Bains line to Evolution Bugzilla-Product: Evolution Bugzilla-Component: Calendar Bugzilla-Version: 2.0.3 Description: Evolution needs a Marcus Bains line: http://people.csail.mit.edu/u/r/rahimi/public_html/marcus-bains-line/ I think it would be easy to add (I added a simple version to the sidebar of the calendar in about an hour. I've never worked with evolution source before). I'll volunteer to work on this, but could use a pointer to the correct place to put it. It looks like the end of e_day_view_main_item_draw() in e-day-view-main-item.c is a good candidate. Ray Jones thouis@mit.edu Unknown reporter: thouis@mit.edu, changed to bugbuddy-import@ximian.com. Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Created attachment 44796 [details] [review] Diff to add Marcus Bains line to calendar (against version 2.0.3)
I've attached my first attempt at a patch. I wrapped the actual drawing code with "if (draw_marcus_bains_line)", which I #defined to 1 for now. I wanted to make it easy to make it a toggleable option. I should have wrapped the timeout code in the same way. The change in appearance is so minor relative to the value of the line (IMO), that it probably should just always be on. Two lines are drawn: a red line in the actual day view main panel, and a white line in the time panel. A timeout callback updates them every minute. The white line is always there (providing a non-intrusive clock), the red line on the current day only. The white line draws under the time text, the red line over the appointments. I hope this is suitable for inclusion.
Created attachment 44797 [details] [review] patch with toggle option for marcus bains line
I just attached a new (superseding) patch against 2.0.3, which includes code to add a toggle for the Marcus Bains Line in the settings for the calendar display. Two caveats: I don't know a lot about Glade programming, so there may be some problems with translations or something else. I generated the diff with dpkg-source, and trimmed out some extraneous stuff caused by difference in built files. I don't believe I removed anything I shouldn't have, but it's possible. I'll verify the patch by reapplying it to virgin source as soon as I get a chance.
please commit patches according to <http://www.gnome.org/projects/evolution/patch.shtml>, which means that you should work on the latest cvs version and add comments to the ChangeLog file. if you attach such a patch file to this bug here, please add the "patch" keyword. thanks in advance... :-)
Created attachment 44940 [details] [review] Same patch but now for HEAD
Note: The question whether or not this feature can go into main has been asked on the evo-hackers mailinglist. http://lists.ximian.com/archives/public/evolution-hackers/2005-March/005199.html
*** bug 273734 has been marked as a duplicate of this bug. ***
Created attachment 45794 [details] [review] Updated patch for HEAD I've updated the patch for HEAD based on some of the comments on evolution-hackers. I've also sent the patch to evolution-patches.
Patch committed to HEAD.
Patch has been reverted until we get the copyright assignment. Sorry for the inconvenience
I sent the form in one or two weeks ago. It should have arrived some time ago.
Re-committed to HEAD!