After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 271567 - messages with horizontal tab character in subject header stay in outbox
messages with horizontal tab character in subject header stay in outbox
Status: RESOLVED FIXED
Product: Evolution Exchange
Classification: Deprecated
Component: Connector
2.0.3
Other All
: Normal major
: 2.6
Assigned To: Sankar P
Evolution QA team
: 269833 328555 (view as bug list)
Depends on:
Blocks: 327514
 
 
Reported: 2005-01-21 10:18 UTC by Bastiaan Bakker
Modified: 2006-03-04 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (2.22 KB, patch)
2006-03-03 08:01 UTC, Sankar P
none Details | Review
Updated patch (2.25 KB, patch)
2006-03-04 08:46 UTC, Sankar P
accepted-commit_now Details | Review

Description Bastiaan Bakker 2005-01-21 10:18:16 UTC
Please fill in this template when reporting a bug, unless you know what you
are doing.
Description of Problem:


Steps to reproduce the problem:
1. create new message
2. put 'text <horizontal tab> text' in subject using copy/paste. (Typing
doesn't work, since the tab will move the cursor to the next input field).
3. send the message

Actual Results:
1. Evolution warns that it couldn't save the message in the 'Sent Items'
folder of the echange server, and that it will save the message in the
local 'Sent' folder instead.
2. Evolution delivers the message.
3. The message stays in the outbox.  

Expected Results:
Evolution should save the message in the central 'Sent Items' folder and
remove if from the outbox folder upon delivery.

How often does this happen? 
Every time.

Additional Information:
The used mail account is an 'Exchange Server' type account. I haven't
tested IMAP or other types of accounts yet.
Comment 1 Not Zed 2005-02-21 11:12:41 UTC
maybe tab is breaking exchange stuff.  it works fine for smtp.

the other problem with things staying in outbox is fixed now, it just
uses the local sent as a fallback, and warns the user what happened.
Comment 2 Arunprakash 2005-09-02 06:03:48 UTC
Now it properly sends the mail even with tabs in the subject.
But by default it saves the sent mails in the local sent items folder. It doesn't
show any warning. And the mail doesn't stay in outbox at all.
Comment 3 Sushma Rai 2006-02-27 14:10:02 UTC
based on comment #2, closing the bug.
Please re-open if you still see the issue with any
newer versions.

Comment 4 Sankar P 2006-02-27 14:19:30 UTC
It still happens. Mail will be sent but cant be attached to the exchange folder. This is because TAB acts a delimitter and hence URL gets garbled. Reopening.
Comment 5 Sankar P 2006-02-27 14:19:57 UTC
*** Bug 328555 has been marked as a duplicate of this bug. ***
Comment 6 Sushma Rai 2006-02-27 14:28:25 UTC
*** Bug 269833 has been marked as a duplicate of this bug. ***
Comment 7 Sankar P 2006-03-03 07:59:05 UTC
Hindering the mail-import operation. Hence will affect the user migration from Outlook. So increasing the severity and retargetting for 2.6
Comment 8 Sankar P 2006-03-03 08:01:14 UTC
Created attachment 60533 [details] [review]
Fix
Comment 9 Sushma Rai 2006-03-03 12:45:03 UTC
As I understand, this check will be performed during
1. import
2. copy mails to exhcnage folder
3. move mails to exchange folder
4. store sent items in exchange account's sent folder and
5. apply filter

I think this check will hit the performance in case of applying filters
on loading evolution. As of new, with the huge mail boxes and remote servers
loading exchange account seems to be slow.

I feel, if we can send mail and on failure from server, check the error code
and based on that, modify the subject and resend the mail, it'll be better.

apart from these  GString "new_subject" needs to be freed. 
and you might want to handle NULL subject mails also.
Comment 10 Sankar P 2006-03-04 06:39:20 UTC
When we copy mails within Exchange folders, append-message will not be called. So filters wouldnt give a performance hit due to this parsing. There is a memory leak in new_subject. Will free it before committing.
Comment 11 Sankar P 2006-03-04 08:46:25 UTC
Created attachment 60624 [details] [review]
Updated patch
Comment 12 Sushma Rai 2006-03-04 09:30:38 UTC
Please use g_string_free for freeing GString before commiting.