GNOME Bugzilla – Bug 270376
skype name field
Last modified: 2008-12-08 11:02:38 UTC
since skype gets a growing comminity - not only under opensource community - i would like to see beside the icq/msn/yahoo/jabber fields also a 'skype' field.
we can look in 2.3, 2.1 is already in all kinds of freezes.
retargetting from 2.3 to 2.5
will not be fixed in the 2.5 timeframe, retargetting to "future".
Pidgin has now a plugin for integrating Skype and Pidgin can be inegrated in Evolution. So it would be cool getting a "Skype" field in nearer futures. Then contacts using skype could shown up automaticly in Pidgin and Skype when they added in Evolution. http://www.myjobspace.co.nz/images/pidgin/ Thanx.
Created attachment 106350 [details] [review] Adds skype contact to the addressbook.
I dont know if this patch works, but maybe can save some work to somebody. Please comment it so I can correct it in case is not working. Rgds Saxa
2.23.x stuff. But I'm sure that the patch needs some work at e-d-s side. Search for "GADU" and "Gadu" in e-d-s you will see what you need to do more.
Created attachment 106415 [details] [review] Adds skype contact to the addressbook in evolution-data-server This patch should hopefully add the Skype field to the addressbok in evolution-data-server. Please comment it so I can add/correct if something is wrong. Rgds Saxa
Sasa, I'm gonna look at this after a week or so. Sorry for the delay.
Srinivasa, its ok take your time. I will be away from my home in the next week for a period of 2 weeks, so if something I will look into it later.
i can't see any reason for NEEDINFO.
*** Bug 521541 has been marked as a duplicate of this bug. ***
Bumping version to a stable release.
@ Srinivasa, have you looked at the patch ? @ Andre, can you explain what you mean with NEEDINFO ? Sasa
Sasa, I will get it reviewed this week. I was off during the last weeks.
+ E_CONTACT_IM_SKYPE_HOME_1, /* Synthetic string field */ + E_CONTACT_IM_SKYPE_HOME_2, /* Synthetic string field */ + E_CONTACT_IM_SKYPE_HOME_3, /* Synthetic string field */ + E_CONTACT_IM_SKYPE_WORK_1, /* Synthetic string field */ + E_CONTACT_IM_SKYPE_WORK_2, /* Synthetic string field */ + E_CONTACT_IM_SKYPE_WORK_3, /* Synthetic string field */ These has to be just before E_CONTACT_FIELD_LAST otherwise it break ABI. Ross, do you remember, you did something to avoid ABI while adding new fields to EContact? Am I saying in sync with that?
You want me to correct this ?
Sasa, with out that it is definitely an ABI break and I dont want to do it surely.
Any updates? @Sasa, were you able to do any corrections?
Sorry, I have not been able to work anything on that bug. I will try to get done something during this month , the problem is that on my laptop I have not installed yet the 2.23.x series of gnome.
This will break UI freeze then, let's target this for early inclusion into 2.25.
Created attachment 122112 [details] [review] proposed eds patch (updated, not mine) for evolution-data-server; just updated previous patch, which doesn't crash Evolution. A little extension to google backend too. There will be required some changes on Evolution's part to let it work fully anyway.
That looks good to me.
Created attachment 122128 [details] [review] proposed evo patch for evolution; here's the evolution's part. It seems the em-contact-editor-im.c/.h is not used, strange, isn't it? Maybe you'll want other icon for the Skype contact field, I do not know.
Patch committed to SVN trunk as r9811 http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=9811
Haven't tested, but should be Ok. Just and commit Milan.
Committed to trunk. Committed revision 36849. I only removed the part for configure.in, because the eds version is set already.