GNOME Bugzilla – Bug 269749
Multiple signatures can be created with the same name
Last modified: 2013-09-10 14:04:09 UTC
Description of Problem: I can add multiple signatures with the same name from an account's preferences. By "signatures" I mean the bit of text at the end of mails, not digital signatures. Steps to reproduce the problem: 1. Go to the menu Tools -> Settings. 2. Double click on an account name. 3. Click on "Add New Signature". 4. Type in some signature. It will be called "Unnamed". 5. Click on "Add New Signature" again. 6. Add another signature called "Unnamed". Actual Results: I end up with multiple signatures with the same name. Expected Results: Maybe it should object to multiple signatures having the same name? How often does this happen? Every time I try it. Additional Information: I upgraded from Evolution 1.4 in Fedora Core 2 to Evolution 2.0.2 in Fedora Core 3. When it asked me if I wanted to keep a back-up of my old evolution directory, I said no. All my mail is stored remotely, so I wasn't bothered about my old preferences. I access mail via IMAP. [rich@katrina ~]$ !ls ls -la ~rich/.evolution/signatures/ total 52 drwx------ 2 rich rich 4096 Nov 20 15:13 ./ drwxrwxr-x 8 rich rich 4096 Nov 19 17:33 ../ -rw-rw-r-- 1 rich rich 192 Nov 20 15:12 signature-0 -rw------- 1 rich rich 0 Nov 15 22:32 signature-1 -rw-rw-r-- 1 rich rich 191 Nov 15 22:34 signature-2 -rw-rw-r-- 1 rich rich 6 Nov 20 15:13 signature-3 -rw-rw-r-- 1 rich rich 8 Nov 20 15:13 signature-4 I'm not sure what happend to signature-1 in the UI. [rich@katrina ~]$ rpm -qi evolution Name : evolution Relocations: (not relocatable) Version : 2.0.2 Vendor: Red Hat, Inc. Release : 3 Build Date: Sat 23 Oct 2004 01:20:07 BST Install Date: Sat 13 Nov 2004 23:36:55 GMT Build Host: tweety.build.redhat.com Group : Applications/Productivity Source RPM: evolution-2.0.2-3.src.rpm Size : 26893742 License: GPL Signature : DSA/SHA1, Tue 26 Oct 2004 17:29:32 BST, Key ID b44269d04f2a6fd2 Packager : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla> URL : http://www.ximian.com/ Summary : GNOME's next-generation groupware suite Description : Evolution is the GNOME collection of personal information management (PIM) tools. Evolution includes a mailer, calendar, contact manager and communication facility. The tools which make up Evolution are tightly integrated with one another and act as a seamless personal information-management tool.
Created attachment 44411 [details] Screenshot showing multiple signatures with the same name
(Still a bug in Evo 2.2.2, was also filed downstream here: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=128472 ) Changing component from UI to Mailer, since UI is deprecated as a component these days.
Evolution also allows signatures to be saved without a name. I guess this is a bug and not a feature. Two new strings must be added. Should be doable on or before 2.5
Created attachment 53003 [details] [review] Adds an _ to the signature name if it is found null or already existing. Adding an underscore is in my view better than popping up yet another dialog.
I guess we should set an exception if name is there, instead of just appending the underscore.
Doing it silently doesn't seem very user friendly. I think the user should be told that the name already exists, rather than silently creating one with an underscore added. Otherwise the user may not notice. If the user then goes to select a signature, how are they going to know what the difference is between "signature" and "signature_"?
Created attachment 53281 [details] [review] This patch pops up a dialog rather than appending an _ - Enhances Signature-Preferences. - Added shortcuts for common operations. -- Delete on Del key -- Edit on Dbl.Click - Prevents adding duplicate and NULL signatures, through two new strings.
Created attachment 53283 [details] [review] Removes a few compilation warnings
Code committed to HEAD. Check with latest source.