GNOME Bugzilla – Bug 267402
can not specify https URL for a remote calendar location
Last modified: 2013-09-10 14:03:47 UTC
Summary pretty much says it all. When creating a new "On the Web" calendar, you can enter a URL only with http: or webcal: protocols. Entering https: disables the OK/Add Calendar button. Using evolution-2.0.0-2 Fedora Development build (Build date Tue 21 Sep 2004 05:32:47 AM EEST)
*** bug 269892 has been marked as a duplicate of this bug. ***
*** Bug 274542 has been marked as a duplicate of this bug. ***
We need to have a checkbox to allow the user to specify 'secure connection', and have a property on the ESource for that, so that the webcal backend replaces webcal: with http or https as appropriate
Created attachment 56564 [details] [review] HTTPS support in Evolution Hi, Here is patch 1 of 2 for HTTPS remote calendar support. This patch is for Evolution 2.5.3. A second for Evolution-data-server 1.5.3 is required. Cheers, Tony
Created attachment 56565 [details] [review] HTTPS support in Evolution-data-server Patch 2 of 2 for HTTPS remote calendar support.
Created attachment 56806 [details] [review] Evolution patch with fixes as per review comments Hi, Here is an updated patch with fixes as per review comments from evolution-patches mailing list. Tony
Please add the Changlog of the changes made. I don't think any copy right assignement would be needed fot this since this is not a major enhancement.
Created attachment 57368 [details] [review] EDS patch with ChangeLog entry Hi, I've added a ChangeLog entry for EDS. The 2nd patch for Evolution already has a ChangeLog entry. Thanks, Tony
Added an accelerator in the check box. Fix has been committed :)
I think that this bug is still open. In the first patch versions the property was named "secure" but in the version with fixes as per review comments it was changed to use_ssl in the patch to evolution, but not to evolution-data-server. So the evolution plugin set use_ssl but evolution-data-server looks for secure. I have tried to change the plugin to set both use_ssl and secure, and now it works. Sincerely Mikael
this would explain why it is not working and why evolution sends out http requests instead of https. Also port 80 is used instead of 443. If I manually change the port to 443 it complains about a broken connection. I'm using version 1.6.1 of EDS on ubuntu 6.06
See also bug 346283. Duplicate? I still see this in 2.7.91, please reopen.
@mikan: Yes, confirmed: in EDS 1.7.91 -- const char *secure_prop = e_source_get_property (source, "secure"); in Evo 2.7.91 -- e_source_set_property (source, "use_ssl", "1"); Annoying.
... and indeed, changing the line in EDS to use the same as evolution does make it work! However, it still only works for unauthenticated https... but that's another bug I suppose.
Fix has been committed in EDS to check for "use_ssl" property.
chentill: May I ask which release will have this? is it in 2.7.92? Thanks for fixing this!
No it is not part of 2.7.2 release. It will part of the evolution-data-server-1.8 release.
The fix is buggy and causes crashes on eds 1.8.0. See this Ubuntu bug: https://launchpad.net/distros/ubuntu/+source/evolution-data-server/+bug/58940 Patch coming...
Created attachment 72907 [details] [review] Patch to fix eds crash Please apply this ASAP
Committed the fix. Mikael, i think this would fix the bug 354545, please a look and close the bug.
No permissions to close... will test on the Ubuntu build, though.
Ok np. Please feel free to add a comment to the bug if it works fine. I can close the bug. Thanks in advance :)