GNOME Bugzilla – Bug 259536
Missing Gadu-Gadu Messenger in Contact entry
Last modified: 2006-09-08 16:29:18 UTC
Description of Problem: There is possibility in contact entry selecting few popular instant messengers for contacting person, but one the list is missing the most popular messenger in my country (Poland) - Gadu-Gadu, which is supported by Gaim. The most important thing is that, Gadu-Gadu is informally stndard for communication in my country, and other IMs like MSN, Yahoo or ICQ are not in use. I've made two patches for Evolution and Evolution Data Server to fix this.
Created attachment 43803 [details] [review] Evolution patch
Created attachment 43804 [details] [review] EDS patch
Artur: please submit your patch to evolution-patches mailing list. You may need to subscribe, see http://lists.ximian.com
OK, done :) Thx for info.
Created attachment 43850 [details] [review] Fixed and tested verion of evolution Gadu-Gadu IM contact patch
Created attachment 43851 [details] [review] Fixed and tested patch which adds Gadu-Gadu support to stored IM's contacts in EDS
adding "patch" keyword
marking the first patches as obsolete because the latter ones are updates on them
Created attachment 59262 [details] [review] updated Evo patch updated fox 2.5.x
Created attachment 59263 [details] [review] updated e-d-s patch updated for recent e-d-s
We are using both patches since about 2 years in PLD Linux Distribution without smallest problems. Would be great to see them included upstream.
This chnages the EContactFieldInfo[] structure and also EContactField enum. Changing the ABI was not allowed in 2.5.x, because it would require changes in some other applications. We can take this patch whenever we get approval for ABI breaks.
didn't we want to break the ABI for 2.8 iirc, so this could be reviewed?
I am not sure about ABI break during 2.8. Harish?
(and i don't remember exactly where i read that, guess it had something to do with the camel version naming)
any chance to see it included?
thanks for the patch, but it cant be committed because I cant break the ABI. Changing the structure EContactFieldInfo and enum EContactField will cause a lot of applications to break.
devashish: so we can break the ABI for bug 313533, but not for this one here? can you explain that to me? :-)
okay, seems because this would break just "too many apps"...
sad but true.
devashish, what's the plan? ignore this patch? or can we get it in for early 2.9 and inform all of maintainers of depending apps, so they do have enough time to port their apps? if this is the defacto IM standard for poland, we should not ignore this...
Seems to me that the ABI sanctity has already been violated - I suggest we go ahead and lump all the patches in one stroke with additional padding for future. Can we attempt this in 2.8.x (the deadline is July 24)
harish: thanks so much. if you would like to have my list of abi-break patches, just ask. :-)
devashish: *POKE* - may i ask for some speed? deadline is on monday. thanks in advance.
Finally this in, so how many people were waiting for this. cheer up andre.
Finally this is in, so how many people were waiting for this. cheer up andre.
great news! Devashish, thanks a lot! :-)
Big thanks to Andre - your involvement was incredible. You saved this bug from lost in the depth of bugzilla.
*** Bug 349162 has been marked as a duplicate of this bug. ***
fryderyk, the next time i'm in poland you owe me a beer ;-)
ufffff