GNOME Bugzilla – Bug 240762
Cannot edit the '_Address Cards' View
Last modified: 2005-12-20 15:17:00 UTC
When going into the Define Views under the View menu, I can edit the Phone List view and the By Company view but not the Address Cards view..if I copy the address cards view and try to edit that it won't work either. It's repeatable everytime.. I even nuked the configuration and started clean and it still will not let me edit the view.
This bug still exists in Evolution 1.4
I can edit them. Maybe a local issue.
What do you think could be the problem then?? I just ran evolution as an entirely different user on my system that has a CLEAN home directory. (adduser dummy) ran evolution as him and tried to edit the address book views.. I can edit _Phone List, By _Company, but i can not edit _Address Cards.. the edit button does nothing when I select that view.. This is with evolution 1.4 on a redhat 7.3 system.
I can verify this issue in 1.4.5 and 1.5.3 versions. Rescheduling to 1.5.5.
I could reproduce this... and same for the Calendar too. I couldn't edit Week view, Months views.
Not a regression.
now it's "view | current view | define views...", still valid in evolution-2.1.3.2.0.200501160930-0.snap.ximian.10.1.
in gal_view_edit() of gal-view.c, if edit function is null, we might need to popup a dialog or just disable the edit button. Please refer to etable_selection_change_forall_cb() in gal-defined- views-dialog.c, too.
Created attachment 45014 [details] [review] patch
Created attachment 45015 [details] [review] evolution side patch
still valid in evolution-2.2.0.0.200503210410-0.snap.ximian.10.1, retargetting to 2.3.
uh yeah, adding patch keyword by the way.
*** bug 234778 has been marked as a duplicate of this bug. ***
patch has been committed
Reproducable in Evolution 2.4. Reopening the bug.
confirmed Evolution has the changes in the patch. Gal issue?
I already have a new patch to fix this.
*** Bug 229844 has been marked as a duplicate of this bug. ***
Address cards view cant be edited, since it doesnt have any customizations like other views like table view has. So it can't be edited. Atleast this is what i can understand from the code. For example Phone list has name/email etc which people might prefer to change, so it makes sense to disable edit. It would even make sense to avoid creating a new type for card view, since it cant be no different than the existing one. This applies to day/other views in calendar also. Closing it. But the bug is that built-in (default created) views should be allowed to be edited, which is happening and it is fixed to head.