After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 173061 - patches to build with GCC 4
patches to build with GCC 4
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: python
0.94
Other Linux
: Normal normal
: 0.95
Assigned To: Hans Breuer
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2005-04-08 13:17 UTC by Stanislav Brabec
Modified: 2005-10-08 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dia-gcc4.patch (591 bytes, patch)
2005-04-08 13:18 UTC, Stanislav Brabec 		none Details | Review
dia-gcc4.patch (560 bytes, patch)
2005-04-11 10:35 UTC, Stanislav Brabec 		none Details | Review
Patch for Ubunto to make dia compile with GCC 4.0 (1.28 KB, patch)
2005-04-18 12:37 UTC, gnome 		none Details | Review

Description Stanislav Brabec 2005-04-08 13:17:45 UTC 
Distribution/Version: SuSE Linux 9.3

There is a small patch which makes dia compilable with GCC 4.

Note that in pydia-object.h, you need to include both python object.h and dia
object.h.
Comment 1 Stanislav Brabec 2005-04-08 13:18:23 UTC 
Created attachment 39838 [details] [review]
dia-gcc4.patch
Comment 2 Lars Clausen 2005-04-10 15:17:42 UTC 
Is the include_next directive Ansi C?
Comment 3 Stanislav Brabec 2005-04-11 10:35:32 UTC 
Created attachment 45129 [details] [review]
dia-gcc4.patch

Sorry, there were residues of my previous attempts. There is a patch without
include_next. It will work, if order of includes will not change:
#include "object.h" includes Python header
#include "lib/object.h" includes Dia header
Comment 4 Lars Clausen 2005-04-11 20:53:05 UTC 
Changing to python component
Comment 5 gnome 2005-04-18 12:37:44 UTC 
Created attachment 45397 [details] [review]
Patch for Ubunto to make dia compile with GCC 4.0

Here is the patch I applied to compile dia 0.94.0-7ubuntu1 in Ubuntu Breezy (we
are switching to GCC 4.0).

I find it cleaner than removing parse_path (seems to be use in svg functions).
Comment 6 Hans Breuer 2005-04-23 17:09:49 UTC 
It striked me odd that there would be two different files to be 
included with one include statement, so I've solved it with the
following change :

2005-04-23  Hans Breuer  <hans@breuer.org>

	* plug-ins/python/diamodule.c plug-ins/python/pydia-object.h
	  plug-ins/python/pydia-properties.h : use lib/ prefix for
	Dia internal headers with too common names (fixes bug #173061)
Comment 7 Hans Breuer 2005-10-08 20:36:49 UTC 
Adjusting target to help finding 0.94 dups already fixed