After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172867 - allow stock labels to show through, be nice to translators
allow stock labels to show through, be nice to translators
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.10.x
Other All
: High normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2005-04-06 21:10 UTC by Alan Horkan
Modified: 2005-04-15 10:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
patch to let stock menu labels show through (4.40 KB, patch)
2005-04-06 21:10 UTC, Alan Horkan 		none Details | Review

Description Alan Horkan 2005-04-06 21:10:05 UTC 
Translation is hard work, nobody wants to have to translate the same
thing twice and it makes sense to use the GTK_STOCK items as much as
possible.  (It is not obvious from the GtkActionEntry documentation how
to do this but Jody Goldber of Gnumeric fame explained how it is done)

The following patch corrects the use of GtkActionEntry so that the stock
labels show through and in some cases (like Open, Save, Close, Copy,
Cut, Paste) I've also allowed the stock keybindings to show through too.

The patch includes a changelog entry.
Comment 1 Alan Horkan 2005-04-06 21:10:39 UTC 
Created attachment 39773 [details] [review]
patch to let stock menu labels show through
Comment 2 Paolo Bacchilega 2005-04-10 09:10:34 UTC 
does this patch break string freeze?
Comment 3 Alan Horkan 2005-04-10 13:13:51 UTC 
the bugzilla mail I got sent about this had a borked link in it, I think there
must have been problems with the bugzilla upgrade
 http://bugzilla.gnome.org/show_bug.cgi?id=3D172867

This shouldn't break the string freeze, all these strings should already be
translated in GTK and if anything this should mean less translation work.  
I would still urge you to inform the traslators and but the potential risk of
this patch is extremely low.  

As this bug includes a patch and you have acknowledged it, it seems fair to mark
it New.
Comment 4 Paolo Bacchilega 2005-04-15 10:16:49 UTC 
commited to CVS HEAD now, thank you.