After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172543 - "Cancel" when overwriting shouldn't replace complete track with partial one
"Cancel" when overwriting shouldn't replace complete track with partial one
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: ripping
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
: 172542 (view as bug list)
Depends on:
Blocks: 172548
 
 
Reported: 2005-04-03 20:21 UTC by Matthew Paul Thomas (mpt)
Modified: 2008-02-13 16:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Patch (3.31 KB, patch)
2008-01-26 22:35 UTC, Matthew Martin
none Details | Review
Improved Patch (3.31 KB, patch)
2008-02-13 16:27 UTC, Matthew Martin
committed Details | Review

Description Matthew Paul Thomas (mpt) 2005-04-03 20:21:25 UTC
Distribution/Version: Ubuntu Hoary preview

Steps to reproduce:
1.  Rip a CD.
2.  By mistake, start ripping the same CD into the same folder in the same
    format.
3.  Realize your mistake, and click "Cancel".

What should happen:
*   You still have a complete version of every track.

What actually happens:
*   The complete file for the track you were in the middle of ripping is
    replaced by a partial file.

So, if there's a file in the same place as where you're ripping a track to, rip
to a temporary file instead, and replace the existing file with the temporary
file only once the track is finished.
Comment 1 Ross Burton 2005-04-04 15:16:41 UTC
*** Bug 172542 has been marked as a duplicate of this bug. ***
Comment 2 Matthew Martin 2008-01-26 22:35:16 UTC
Created attachment 103788 [details] [review]
Patch
Comment 3 Matthew Martin 2008-02-13 16:27:44 UTC
Created attachment 105163 [details] [review]
Improved Patch
Comment 4 Ross Burton 2008-02-13 16:35:05 UTC
Committed, thanks!