GNOME Bugzilla – Bug 172488
art.dot.gnome not standards compliant.
Last modified: 2005-07-14 18:42:07 UTC
see http://validator.w3.org I'll put some patches up real soon.
Created attachment 39619 [details] [review] fixes some xhtml compliance of the header/footer I'm assuming the other stuff causing errors on the front page is in the database.
I fixed the <link> short tag error, but I don't think the <ul> tag needs to be inside a <p> tag. I updated the copyright.php and it is now fully XHTML, which shows the headers are too. The rest of the stuff causing errors is mostly database. Html should not really be in the database, so this needs to be removed and a proper parsing needs to be done to allow formatting (like what is currently used for the comments). Once that is done we can find the XHTML errors in the code more easily.
Created attachment 39642 [details] [review] directly inputs html instead of using print(), made more xhtml strict ready (<b> -> <strong>; <center> -> <div align="center"> another thing we could to do make finding errors more easily is seperate the lines in the html output. Also, if we escape php and output html directly, it is supposed to be faster (but it's a lot easier to read, because you do not have to escape quotes).
Created attachment 39643 [details] [review] made includes.inc.php xhtml compliant, and more xhtml strict ready
Created attachment 39647 [details] [review] in faq.php: added missing </li> tag, changed <p> to <br /><br />
Created attachment 39658 [details] [review] various xhtml compliance fixes. at least, most of the obvious ones. this patch includes 39643 & 39647.
I have comitted patch 39658. I also did some other work and I think most, if not all, pages are now XHTML compliant. Next thing to do is to make sure all output from the database is parsed to html properly. I renamed the parse_comment() function to html_parse_text(), which should be used every time text is taken from the database.
I think we're almost 100% standards compliant now, so marking as fixed. This is now an ongoing objective as art.gnome.org is developed. However, feel free to re-open this bug with information on any new standards issues if they come to light.