After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172479 - EggTrayIcons can still appear 1 pixel wide
EggTrayIcons can still appear 1 pixel wide
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Libegg maintenance
Libegg maintenance
Depends on:
Blocks:
 
 
Reported: 2005-04-03 02:42 UTC by Robert McQueen
Modified: 2005-06-06 20:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes tray icon appearing 1 pixel wide (2.93 KB, patch)
2005-04-03 02:45 UTC, Robert McQueen
none Details | Review

Description Robert McQueen 2005-04-03 02:42:56 UTC
This is a really old bug which I think got fixed by Owen 18 months ago in Gaim
and rhn-applet where it was manifesting quite frequently (see RedHat Bugzilla
#75225 and #106985 and countless others). However, the patch seems not to have
made it up to libegg CVS, so the bug still happens for countless other users of
Gaim on other distributions, and amusingly because none of the Gaim developers
could work out what the change was for, isn't included in Fedora's Gaim RPMs any
more either. I'm not sure what issue the patch fixes but I've pulled it out and
will attach it to this bug so it doesn't get lost again. If someone could
sanity-check and apply it, Gaim can pull a new eggtrayicon.c and there will be
much rejoycing.
Comment 1 Robert McQueen 2005-04-03 02:45:25 UTC
Created attachment 39613 [details] [review]
fixes tray icon appearing 1 pixel wide

Patch extracted by diffing eggtrayicon.c 1.5 from libegg CVS, and eggtrayicon.c
from rhn-applet 2.1.16. Relevant ChangeLog entry:

Tue Sep 30 21:47:38 CEST 2003 Daniel Veillard <veillard@redhat.com>

	* eggtrayicon.c: Owen managed to reproduce the 1pixel wide
	  bug, applied the client side of the patch bug #75225
Comment 2 Robert McQueen 2005-06-01 18:23:41 UTC
Hellooo? This keeps happening in many EggTrayIcon-using applications. There's a
patch ready to apply. Go go go. :)
Comment 3 Robert McQueen 2005-06-06 20:44:37 UTC
Patch merged into CVS:

2005-06-05  Kjartan Maraas  <kmaraas@gnome.org>

	* libegg/tray/eggtrayicon.c: (egg_tray_icon_manager_filter),
	(egg_tray_icon_update_manager_window),
	(egg_tray_icon_manager_window_destroyed), (egg_tray_icon_realize):
	Patch from Fedora, by Daniel Veillard to fix 1 pixel eggtrayicon
	Closes bug #172479. Thanks to Robert McQueen for extracting the
	patch from the Fedora version of eggtrayicon.c