After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172231 - possible leak
possible leak
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: MIME data
cvs (head)
Other All
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-31 11:56 UTC by Kjartan Maraas
Modified: 2005-04-01 16:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
patch for leak (620 bytes, patch)
2005-03-31 11:56 UTC, Kjartan Maraas 		none Details | Review
updated patch (759 bytes, patch)
2005-03-31 12:19 UTC, Kjartan Maraas 		none Details | Review

Description Kjartan Maraas 2005-03-31 11:56:06 UTC 
While looking for other leaks I found something that looks leaky in
gnome-vfs-mime-info-cache.c. Attaching a patch
Comment 1 Kjartan Maraas 2005-03-31 11:56:44 UTC 
Created attachment 39494 [details] [review]
patch for leak
Comment 2 Christophe Fergeau 2005-03-31 12:01:58 UTC 
The same function misses a 
   g_key_file_free (key_file);
in (at the beginning)
	if (load_error != NULL) {
		g_error_free (load_error);
		return FALSE;
	}

	if (g_key_file_has_key (key_file, DESKTOP_ENTRY_GROUP,
				"OnlyShowIn", NULL)) {

I think. The patch looks good otherwise.
Comment 3 Kjartan Maraas 2005-03-31 12:19:29 UTC 
Created attachment 39495 [details] [review]
updated patch

Totally missed that one. Updated patch attached. Ok to commit?
Comment 4 Kjartan Maraas 2005-04-01 16:41:52 UTC 
Commiting to both branches. Christophe acked the latest patch on IRC.