After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172114 - tarball size element is mandatory though docs say otherwise
tarball size element is mandatory though docs say otherwise
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: James Henstridge
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2005-03-30 15:53 UTC by Damien Carbery
Modified: 2005-04-04 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Damien Carbery 2005-03-30 15:53:13 UTC 
Version details: HEAD
Distribution/Version: JDS3

View jhbuild/doc/jhbuild.xml
Line 1361 states that the 'size' and 'md5sum' attributes are optional.

In jhbuild/modtypes/tarball.py line 223 the code references
codenode.getAttribute('size') without a "if childnode.hasAttribute('size'):"
check like it does for md5sum.

Obviously including a size is a good thing.
Comment 1 Damien Carbery 2005-03-30 16:03:07 UTC 
Change will also need to be reflected in
http://www.gnome.org/~jamesh/jhbuild.html#moduleset-syntax-defs
Comment 2 James Henstridge 2005-04-04 12:32:45 UTC 
2005-04-04  James Henstridge  <james@jamesh.id.au>

	* jhbuild/modtypes/tarball.py (parse_tarball): size attribute of
	<source> element is optional.  Fixes bug #172114.