After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172111 - gok: gok-spy.c should use gconf key for search depth.
gok: gok-spy.c should use gconf key for search depth.
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
1.0.x
Other Linux
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
Depends on:
Blocks:
 
 
Reported: 2005-03-30 15:27 UTC by David Bolter
Modified: 2005-04-05 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (4.01 KB, patch)
2005-03-30 16:03 UTC, David Bolter 		accepted-commit_now Details | Review
improved patch (5.09 KB, patch)
2005-04-04 14:00 UTC, David Bolter 		committed Details | Review

Description David Bolter 2005-03-30 15:27:01 UTC 
Instead of GOK_MAX_SEARCH_DEPTH, this gconf key should be used:
/apps/gok/spy/gui_search_depth
The default should be set to 18 (currently 200) which is the magic number
discovered to be ideal the gok workaround solution to possible cyclic graph
problems like that found in bug #171231.
Comment 1 David Bolter 2005-03-30 16:03:21 UTC 
Created attachment 39448 [details] [review]
proposed fix

This allows us (users) to tweak the gui search depth and breadth parameters.
(also cleans up the code a bit)
Comment 2 bill.haneman 2005-03-30 16:06:24 UTC 
given this value's strong performance impact (it's exponential, after all) I am
a little dubious of allowing it to be set in gconf without some sanity testing
of the min/max values... should we clamp the value to a min of, say, 10, and a
max of 20?
Comment 3 David Bolter 2005-03-30 17:07:22 UTC 
I like leaving it open for debugging purposes. There is no user interface for
these settings (the user has to edit gconf). It is a danger I suppose but a
minimal one IMO.
Comment 4 David Bolter 2005-04-04 00:22:42 UTC 
On second thought, I can live with a min/max.  No need to give out too much rope.
Comment 5 David Bolter 2005-04-04 14:00:41 UTC 
Created attachment 39677 [details] [review]
improved patch

Bill, I'm going to post this before committing as there is no rush on this.
Comment 6 David Bolter 2005-04-05 15:40:49 UTC 
Fixed on head.