Created attachment 39406 [details] [review]
patch to remove cruft

Created attachment 39408 [details] [review]
updated patch

Can this go in?

What ? After 3 months this still hasn't been committed ? The patch is so  
obvious that it shouldn't have taken longer than 1 or 2 days getting committed  
after filling. I wonder if the current gnome-applets maintainer is interested  
in fixing these issues, if not then it would be required to search someone else  
who is willing to do the job - and do it right. Sorry for sounding rude here 
but it's seriously helping no one if the patches are rotting away on b.g.o 
without any attention. 

I appreciate your concern, but this kind of response is not going to help. It's
not exactly the most important patch sitting in bugzilla...

This kind of response is not going to help - maybe! But leaving this kind of  
patches (and we have plenty of them on bgo) doesn't help anyone either. 
  
I agree that this is not exactly the most important patch sitting in bgo, but  
then again the maintainer has to worry on exactly gnome-applets and not  
anything else. 
  
That's the reason why he has accepted to take over gnome-applets to exactly do  
what he is supposed to do, looking at bgo every now and then, committing open  
patches, respond to bugreports, close invalid patches or do some work on the  
applets itself. 
  
Not long ago all gnome-about boxes got replaced with gtk-about boxes in  
gnome-applets, that for my understanding was as important as this patch here,  
removing old cruft and have them replaced with something better. 
  
Now this patchs is totally small it just removes old dead cruft, it got  
reviewed and even tested by me as we both spoke on IRC 3 months ago. 
 
There is also nothing special going on in gnome-applets for the past couple of 
months which means there is nothing important going on either in this package 
within CVS. So if the maintainer would have given his job a lot more care then 
we would have reduced yet again a huge number of open bugreports and small 
patches and would have a clear focus forward for more important things. This 
small patch would have been a bugreport less if it was dealt with care and 
given the needed attention. But well, maybe IRC'ing and Blog'ing is more 
important than fixing GNOME, who knows. 

Kjartan, my apologies. I read this months ago and obviously forgot to approve it.

Ali, while the patch may be obvious, it's not causing anyone any harm. I'm sorry
if you think that "nothing special" has gone on in this module for 3 months. I
too am disappointed to be back above 100 bug reports but time has been against
me. At the moment applets are actually functioning quite well in my opinion,
instead we have been focusing on some more next generation stuff. Unfortunately
this has been going slower then I would have liked, again due to not having
enough hours in the day.

Commited. Thanks.

*** Bug 170191 has been marked as a duplicate of this bug. ***