GNOME Bugzilla – Bug 171911
Patch to provide dbus feed subscription to blam
Last modified: 2005-06-20 20:12:46 UTC
I am currently writing a plugin for epiphany that allows to parse rss feeds in the page you are viewing and "subscribe" to the page's feed. I went on the dbus road, so epiphany do a remote call on dbus to subscribe the feed in the program that answer the call (of course the reader has to run for it to accept the method call). I modified autotools so that dbus compilation is optional, and if not requested then the corresponding files are not built.
Created attachment 39360 [details] [review] blam-dbus-subscription.patch The patch to cvs blam
Created attachment 39361 [details] DBusFeedReader.cs This is to be added in blam/src/
For more info see epiphany bug http://bugzilla.gnome.org/show_bug.cgi?id=171908
- $(CSC) -lib:rss $(RESOURCES) $(BLAM_LIBS) $(ASSEMBLIES) $(BLAM_CSFILES) $(GENERATED_CSFILES) -o $@ + $(CSC) -lib:rss -pkg:dbus-sharp $(DBUS_CSFLAGS) $(RESOURCES) $(BLAM_LIBS) $(ASSEMBLIES) $(BLAM_CSFILES) $(GENERATED_CSFILES) -o $@ I think the -pkg:dbus-sharp part should be in the $ASSEMBLIES variable if and only if the user explicitely said he wanted D-BUS support. Otherwise the patch and DBusFeedReader.cs looks fine, can't really comment on the D-BUS bindings for C#, never used them. Think you could look into the issue with the -pkg:dbus-sharp line as commented above (or if I misunderstood, tell me I'm a dofus :)
Created attachment 39723 [details] [review] blam-dbus-subscription.patch You're not a dofus, great news :) So i changed so now it should be ok, the -pkg was completely unnecessary, and also now it tries to enabe DBUS by default, and if not available, disable it. Is this ok ?
Hi there, just to signal that the extension has been integrated in cvs, and is ready to be shipped with next major release of epiphany. It would be great to also have support on your part at that time :)
Quick note: These lines in the DBusFeedReader should be changed: [DBus.Interface ("org.gnome.rss.FeedReader")] abstract class DBusFeedReaderProxy { public static string Service = "org.gnome.rss.FeedReader"; public static string ObjectPath = "/org/gnome/rss/FeedReader"; [...] into: [DBus.Interface ("org.gnome.feed.Reader")] abstract class DBusFeedReaderProxy { public static string Service = "org.gnome.feed.Reader"; public static string ObjectPath = "/org/gnome/feed/Reader"; [...] Thanks!
It would be nice to see this in blam, even if it's only a configure time 'opt in' option.
Created attachment 48049 [details] [review] Patch as commited.
I commited the patch to CVS, please check if it works as expected.
Created attachment 48051 [details] [review] blam.patch Well the patch you committed was quite not correct ;) This should fix it! Thanks
Feel free to commit.