After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171657 - PATCH: Enable retreival of news feeds present in a visited webpage
PATCH: Enable retreival of news feeds present in a visited webpage
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] Backend:Mozilla
git master
Other All
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-03-25 23:04 UTC by Raphael Slinckx
Modified: 2005-04-08 12:58 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
ephy-rss.patch (8.40 KB, patch)
2005-03-25 23:04 UTC, Raphael Slinckx 		none Details | Review
my version of this patch (12.32 KB, patch)
2005-04-02 20:36 UTC, Christian Persch 		none Details | Review
updated patch (14.71 KB, patch)
2005-04-05 20:00 UTC, Christian Persch 		none Details | Review

Description Raphael Slinckx 2005-03-25 23:04:21 UTC 
The following patch provides a way for epiphany and extensions to be warned when
 a page contains a news feed, by looking at the <link rel="alternate"> tag in
the header.

If the mime-type is either application/rss+xml or application/atom+xml, the
signal is fired (i looked at the favicon code to do that).

There is also a text/xml mimetype used by old rss feeds, but i left it out
because text/xml can be anything..
Comment 1 Raphael Slinckx 2005-03-25 23:04:59 UTC 
Created attachment 39263 [details] [review]
ephy-rss.patch

The patch.

Will be used by my rss extension, to come soon
Comment 2 Raphael Slinckx 2005-03-27 00:32:51 UTC 
"""
is it necessary to resolve the feed uri against the document uri? firefox
doesn't do that... I assume it'll always be an absolute uri, no?
"""

No it isn't it's just that i copied the favicon code, and didn't understand
everything, so feel free to remove what should be :)
Comment 3 Christian Persch 2005-04-02 20:36:30 UTC 
Created attachment 39601 [details] [review]
my version of this patch

I changed the signal name to "ge_feed_link" --- since it also dispatches atom
feeds, ge_rss wasn't really appropriate. I'm open for better names, though.

I incorporated this into the existing DOMLinkAdded handler; no point adding
more handlers.
Comment 4 Raphael Slinckx 2005-04-05 19:39:47 UTC 
Seems good, the name is ok too !

However, i would resolve the url anyway (not like i said before) because if a
site provide a feed url relative to the site, it will not work..
Comment 5 Christian Persch 2005-04-05 20:00:49 UTC 
Created attachment 39721 [details] [review]
updated patch
Comment 6 Christian Persch 2005-04-08 12:58:27 UTC 
Check in on HEAD.