After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171619 - uses GnomeIconTheme which is deprecated
uses GnomeIconTheme which is deprecated
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.18.x
Other All
: High normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2005-03-25 18:16 UTC by Kristof Vansant
Modified: 2007-06-04 15:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Switch GnomeIconTheme to GtkIconTheme (3.19 KB, patch)
2005-05-04 21:19 UTC, Jan de Groot 		none Details | Review
Improved patch that romves the last parts (1.92 KB, patch)
2007-05-12 21:39 UTC, Jan de Groot 		accepted-commit_now Details | Review

Description Kristof Vansant 2005-03-25 18:16:29 UTC 
Please describe the problem:
src/window.c
src/dlg-batch-add.c



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jan de Groot 2005-05-04 21:19:05 UTC 
Created attachment 46036 [details] [review]
Switch GnomeIconTheme to GtkIconTheme

Patch is against CVS HEAD.

I don't know if GtkIconTheme has a function to get an icon that's associated
with a MIME type, so I left that function alone.

The egg-recent code used in file-roller seems to use GnomeIconTheme too, I
didn't touch that with this patch.
Comment 2 Jan de Groot 2007-05-12 21:39:59 UTC 
Created attachment 88099 [details] [review]
Improved patch that romves the last parts

Improved patch that applies to SVN trunk as of today.

Improvements made to previous patch:
- g_object_unref is removed for icon_theme, API docs say we should not do this
- icon is loaded directly like in fr-window.c without difficult gtk-icon-info calls
- unused includefile is removed

Other things:
- theme_changed_cb in fr-window.c takes a GtkIconInfo instead of GnomeIconInfo
Comment 3 Paolo Bacchilega 2007-06-04 15:03:44 UTC 
patch applied to trunk, thanks.