After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171593 - uses GnomeIconTheme which is deprecated
uses GnomeIconTheme which is deprecated
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other All
: High normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 171590 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-25 14:59 UTC by Kristof Vansant
Modified: 2007-01-14 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GnomeIconTheme -> GtkIconTheme patch (7.54 KB, patch)
2005-05-05 10:00 UTC, Jan de Groot 		none Details | Review
Updated GnomeIconTheme -> GtkIconTheme patch. (8.29 KB, patch)
2006-10-02 13:02 UTC, Michael Chudobiak 		none Details | Review
reverted patch (+/-s reversed) (8.59 KB, patch)
2007-01-14 15:43 UTC, Michael Chudobiak 		none Details | Review

Description Kristof Vansant 2005-03-25 14:59:03 UTC 
Please describe the problem:
libgthumb/gth-file-view-thumbs.c
libgthumb/gth-file-view-list.c
src/dlg-photo-importer.c
src/main.c


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jan de Groot 2005-05-05 10:00:01 UTC 
Created attachment 46048 [details] [review]
GnomeIconTheme -> GtkIconTheme patch

Still uses libgnomeui functions to lookup an icon name together with a mime
type, but this function was not marked as deprecated in the documentation,
neither could I find a GtkIconTheme function that does the same.
Comment 2 Teppo Turtiainen 2005-07-25 18:38:23 UTC 
*** Bug 171590 has been marked as a duplicate of this bug. ***
Comment 3 Michael Chudobiak 2006-10-02 13:02:04 UTC 
Created attachment 73845 [details] [review]
Updated GnomeIconTheme -> GtkIconTheme patch.

The patch has been updated against current CVS.
Comment 4 Michael Chudobiak 2007-01-12 19:16:07 UTC 
Modified version of patch committed to svn rev 1262. Thanks, Jan!

- Mike
Comment 5 Michael Chudobiak 2007-01-14 15:42:56 UTC 
Re-opening bug - something broke in the photo inporter (bug 396474). I'm not sure what the problem is right now, so I've reverted the patch from svn. The reverted changes are listed in the attachment below. Does anyone see any obvious problems?

- Mike
Comment 6 Michael Chudobiak 2007-01-14 15:43:57 UTC 
Created attachment 80242 [details] [review]
reverted patch (+/-s reversed)
Comment 7 Michael Chudobiak 2007-01-14 21:30:28 UTC 
The g_object_unref calls for icon_theme had to be removed, as Paolo says in bug 396474. The patch has been re-committed.

- Mike