After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171366 - <LegacyDir> Internet sub-menu not merged with normal Internet sub-menu
<LegacyDir> Internet sub-menu not merged with normal Internet sub-menu
Status: RESOLVED FIXED
Product: gnome-menus
Classification: Core
Component: layout
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-menus dummy account
gnome-menus dummy account
: 305772 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-23 14:55 UTC by Sebastien Bacher
Modified: 2005-06-01 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot of the issue (20.80 KB, image/jpeg)
2005-03-23 14:58 UTC, Sebastien Bacher 		  Details
verbose log (381.89 KB, text/plain)
2005-03-23 16:30 UTC, Sebastien Bacher 		  Details
fix (3.02 KB, patch)
2005-03-24 09:04 UTC, Mark McLoughlin 		none Details | Review

Description Sebastien Bacher 2005-03-23 14:55:00 UTC 
With the 2.10.1 update, the desktop files from /usr/share/applnk/ are listed in
the menus and create some weird duplicates.
Comment 1 Sebastien Bacher 2005-03-23 14:58:36 UTC 
Created attachment 39135 [details]
screenshot of the issue

This screenshot describes the issue.

Now the menu has a duplicated "Internet" category. The new one seems to come
from "/usr/share/applnk/Internet/lynx.desktop".

/usr/share/applnk/Internet/lynx.desktop:
[Desktop Entry]
Type=Application
Exec=/usr/bin/lynx %u
Name=Lynx
Terminal=1
Comment=Lynx
Icon=html
MimeType=text/html
XClassHintResName=Lynx


This desktop file has no category, it should probably not be listed. The WINE
icon in the menu come in the same way from a /usr/share/applnk/wine.desktop.
Comment 2 Mark McLoughlin 2005-03-23 16:08:53 UTC 
The only bug here, I think, is that there are two Internet menus - I would
expect there to be just one Internet menu.

Could you attach the output of MENU_VERBOSE=1 gnome-menu-spec-test ?


(They are being pulled in because of the <KDELegacyDirs/> in the .menu file -
see the menu spec for more details of the whys and wherefors)
Comment 3 Sebastien Bacher 2005-03-23 16:30:20 UTC 
Created attachment 39137 [details]
verbose log
Comment 4 Mark McLoughlin 2005-03-24 09:04:36 UTC 
Created attachment 39188 [details] [review]
fix
Comment 5 Mark McLoughlin 2005-03-24 09:05:13 UTC 
Fixed on HEAD and gnome-2-10:

2005-03-24  Mark McLoughlin  <mark@skynet.ie>

        Fix issue where you could end up with more than one
        menu with the same name - bug #171366

        * libmenu/menu-tree.c: (menu_tree_strip_duplicate_children):
        When deleting an item from the list, make sure our prev pointer
        doesn't point to the deleted one so that we catch any further
        duplicates.
Comment 6 Sebastien Bacher 2005-03-24 12:44:50 UTC 
the patch works fine here, thanks
Comment 7 Mark McLoughlin 2005-05-30 08:14:33 UTC 
*** Bug 305772 has been marked as a duplicate of this bug. ***
Comment 8 Heinrich Wendel 2005-06-01 16:08:44 UTC 
not completly fixed, see bug #305772