After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171243 - When selecting Icons Only Go button still is text
When selecting Icons Only Go button still is text
Status: RESOLVED NOTABUG
Product: epiphany
Classification: Core
Component: Controls
1.6.x
Other All
: Normal trivial
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-03-22 16:22 UTC by shimon
Modified: 2005-12-31 21:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Description shimon 2005-03-22 16:22:48 UTC 
Please describe the problem:
.

Steps to reproduce:
1. Change toolbar to Icons only
2. ???
3. PROFIT!


Actual results:
Go button becomes text only

Expected results:
Go button becoming Icon only

Does this happen every time?
YES!

Other information:
Comment 1 Reinout van Schouwen 2005-03-23 00:49:25 UTC 
Actually the Go button never shows an icon, except in the toolbar editor. Weird
indeed.
Comment 2 Michael Terry 2005-03-25 19:34:32 UTC 
I looked at this.  It is a simple fix - just remove the custom widget creation
code in src/ephy-go-action.c.  However, this makes the default layout look
weird, since the go-icon-plus-text button is taller than the address bar, which
presumably is the reason for the custom code.

We could fix it to behave like a normal button except in the text-below-icon
case where we revert to current behavior...  Or in that case we could should
text beside the icon instead of below it.
Comment 3 Christian Persch 2005-03-25 20:42:31 UTC 
AFAIK, it was a concious decision to make the "Go" button always have text and
no icon, wasn't it, Marco?
Comment 4 Marco Pesenti Gritti 2005-03-26 09:19:59 UTC 
Yeah it was even if I dont quite remember the rationale. Maybe ask Dave Bordoley...