After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170706 - English language names not properly displayed
English language names not properly displayed
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-17 18:34 UTC by Seb Wills
Modified: 2005-03-21 18:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Patch to gdmlangauges.c removing the "en" entry as per my comment (659 bytes, patch)
2005-03-19 21:18 UTC, Seb Wills
none Details | Review

Description Seb Wills 2005-03-17 18:34:02 UTC
Please describe the problem:
If locales of the form en_XX are present, where en_XX is not listed in the
internal list of locale transations in gdmlanguages.c, (for example,
en_IN.UTF-8), then the language is listed as "English (UTF-8)", with no
indication of the country. Thus, in my system which has a number of such locales
installed, I have three or four identical entries which say "English (UTF-8)"
when they should say "English (India)" and so on.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
This behaviour occurs because there is an entry for locale "en" in the internal
list in gdmlanguages.c (whereas all the other entries in that list have a
country, as well as a language). Since the find_lang function falls back to
matching just the language if it can't match country and language, "en_IN"
matches "en", and the internal "en" entry (which just says "English") is used
isntead of the more informative "English (India)" in the external locale.conf.

A simple fix for this would be to simply remove the line for "en" in
gdmlanguages.conf. Locales such as en_ZA which are in that internal list will
behaviour just as before, and locales such as en_IN not in the internal list
will use their name from locale.conf. I don't see any major problems with doing
this. en_XX languages not in the internal list will be filed under 'Other'
rather than 'A-M' in gdmlogin, but that's not a big deal IMO.
Comment 1 Brian Cameron 2005-03-19 02:06:32 UTC
Can you provide a patch?
Comment 2 Seb Wills 2005-03-19 21:18:45 UTC
Created attachment 38949 [details] [review]
Patch to gdmlangauges.c removing the "en" entry as per my comment
Comment 3 Brian Cameron 2005-03-21 18:43:50 UTC
Fixed in CVS head.