GNOME Bugzilla – Bug 170659
hide drop-down arrow if only one palette is available
Last modified: 2005-08-07 16:12:48 UTC
Version details: 2.8.2 I use the charpick applet to quickly access the three or four characters that I use sometimes but are not available on my keyboard. Hence I don't use its feature to switch between multiple palettes. However, the drop-down arrow which lets me choose amongst this one palette is still drawn on the screen, occupying a lot of space on the panel which I could use for better purposes. So please hide this drop-down arrow and hence make the applet narrower in case only one palette is configured.
Seems to make sense. Marking as an enhancement for gnome-lovin'.
Created attachment 38960 [details] [review] patch proposal I'm not sure if it's totally correct, but it works here.
Only zapping through this bug by accident. I gave the patch a glance: g_list_position(curr_data->chartable, g_list_last(curr_data->chartable)); That should be g_list_length(), requires three replacements in the patch. Other than that, looks good. Could you please update the patch, Felix? Thanks.
Created attachment 39847 [details] [review] updated (+working) patch Thanks for the tip. I changed it. I had to take out the length check (= / > 1 list-entry) in populate_menu(), because it wasn't working either way and the function which deletes the list-entries redrew the applet anyway in one case. So the whole checking is now done in the build_table()-function.
Has a patch, needs reviewing.
2005-08-08 Davyd Madeley <davyd@madeley.id.au> * charpick.c: * properties.c: Only show palette selector if there are palettes to select. Closes #170659. Patch from Felix Riemann <felix@hsgheli.de>.