After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170543 - buttons in file->open window and ctrl-L window are not in the same order
buttons in file->open window and ctrl-L window are not in the same order
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
unspecified
Other Windows
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-03-16 09:08 UTC by Olivier Ripoll
Modified: 2005-03-16 23:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
correct behaviour with gtk 2.4 (10.41 KB, image/png)
2005-03-16 09:16 UTC, Olivier Ripoll
Details
wrong behaviour with gtk 2.6 (8.51 KB, image/png)
2005-03-16 09:16 UTC, Olivier Ripoll
Details

Description Olivier Ripoll 2005-03-16 09:08:19 UTC
In gimp 2.2.4, when using gtk 2.4.14, the order of the buttons at the bottom
right of the "file->open" window is [cancel] [open] and when opening the
"location" window (ctrl-L), the order of the buttons is the same.
In gimp 2.2.4 with gtk 2.6.4, the order in the "file->open" window is [cancel]
[open] (as previously), but the order in the "location" window is now [open]
[cancel] (see attached screenshot).

Other information:
Additional info: I filed this as a win32 bug since I cannot check on my linux
PC. It does not show the bug, but is using gtk 2.4.6, and as said previously,
there is no such problem on gtk 2.4.x even on windows.
Gtk 2.6.4 was obtained from the sourceforge page.
Comment 1 Olivier Ripoll 2005-03-16 09:16:00 UTC
Created attachment 38783 [details]
correct behaviour with gtk 2.4
Comment 2 Olivier Ripoll 2005-03-16 09:16:29 UTC
Created attachment 38784 [details]
wrong behaviour with gtk 2.6
Comment 3 Owen Taylor 2005-03-16 15:38:27 UTC
This has to be fixed at the GIMP level when creating the file dialog
by calling gtk_dialog_set_alternative_button_order().

(Or I think it's possible to use the GNOME button everywhere by
 
 g_object_set (gtk_settings_get_default (), 
               "gtk-alternative-button-order", FALSE,
               NULL);
)
Comment 4 Sven Neumann 2005-03-16 17:22:03 UTC
In GIMP CVS, we specify an alternative button order everywhere. Since we don't
do that in GIMP 2.2, we should do as Owen suggested and globally disable the
alternative button order.
Comment 5 Manish Singh 2005-03-16 17:22:46 UTC
I've done up a patch for 2.2, it just needs some testing.
Comment 6 Michael Schumacher 2005-03-16 17:32:06 UTC
Um, I can't reproduce this with GTK+ 2.6.4.
Comment 7 Sven Neumann 2005-03-16 17:35:12 UTC
I guess to be completely correct, we'd have to do this for all screens. For
Win32, I assume it should be sufficient to tweak the settings of the default
screen...

2005-03-16  Sven Neumann  <sven@gimp.org>

	* app/gui/gui.c (gui_init): disable "gtk-alternative-button-order"
	since we don't provide an alternative button order in this branch.
	Fixes bug #170543.
Comment 8 Sven Neumann 2005-03-16 17:36:06 UTC
Yosh, sorry, but I had the change committed already (after testing that my
changes work).
Comment 9 Manish Singh 2005-03-16 19:56:24 UTC
Your change only affected the app, and not plugins:

2005-03-14  Manish Singh  <yosh@gimp.org>

        * libgimpwidgets/gimpwidgets-private.c (gimp_widgets_init): disable
        "gtk-alternative-button-order" here, so the plug-ins get it unset
        too. Completely fixes bug #170543.

        * app/gui/gui.c (gui_int): removed now redundant code.
Comment 10 Sven Neumann 2005-03-16 23:57:50 UTC
Good catch, thanks!