After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170530 - Building gnome-vfs-2.10.0 on DragonFly fails
Building gnome-vfs-2.10.0 on DragonFly fails
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Build
cvs (head)
Other other
: High normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-16 04:07 UTC by YONETANI Tomokazu
Modified: 2005-05-08 13:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
additional patch to add #ifdef __DragonFly__ (1.49 KB, patch)
2005-03-16 14:02 UTC, YONETANI Tomokazu
committed Details | Review

Description YONETANI Tomokazu 2005-03-16 04:07:15 UTC
Version details: 2.10.0

Try to build gnome-vfs-2.10.0 on DragonFly with CCVER=gcc34.

The recently added support for DragonFly(thanks for that!) is missing
a few more pieces to compile it under gcc34(which does not define
a few preprocessor symbols like __FreeBSD__ and __FreeBSD_version
as gcc2.95 does).
Please find the patch to fix it from the following URL:
http://leaf.dragonflybsd.org/mailarchive/submit/2005-03/msg00094.html
Comment 1 Christophe Fergeau 2005-03-16 07:55:40 UTC
By any chance, could you generate a diff and attach it here ? The patch was
inline in the body of the mail, and I fear a simple copy and paste won't be
enough to get it (and I can't test atm).
For the record here is the patch (in case the link disappears for one reason or
antoher):
--- gnome-vfs-2.10.0/modules/cdda-method.c.orig	2005-03-14 18:11:04.000000000 +0900
+++ gnome-vfs-2.10.0/modules/cdda-method.c	2005-03-14 18:11:37.000000000 +0900
@@ -625,7 +625,7 @@
 		if (global_context != NULL) {
 #ifdef __linux__
 			if (strcmp (drive->cdda_device_name,
global_context->drive->cdda_device_name) == 0) {
-#elif defined(__FreeBSD__)
+#elif defined(__FreeBSD__) || defined(__DragonFly__)
 			if (strcmp (drive->dev->device_path,
global_context->drive->dev->device_path) == 0) {
 #endif
 				use_cache = TRUE;
@@ -715,7 +715,7 @@
 		if (global_context != NULL) {
 #ifdef __linux__
 				if (strcmp (drive->cdda_device_name,
global_context->drive->cdda_device_name) != 0) {
-#elif defined(__FreeBSD__)
+#elif defined(__FreeBSD__) || defined(__DragonFly__)
 				if (strcmp (drive->dev->device_path,
global_context->drive->dev->device_path) != 0) {
 #endif
 					/*	Clear old cache */
--- gnome-vfs-2.10.0/libgnomevfs/gnome-vfs-volume-ops.c.orig	2005-03-14
18:11:04.000000000 +0900
+++ gnome-vfs-2.10.0/libgnomevfs/gnome-vfs-volume-ops.c	2005-03-14
18:11:48.000000000 +0900
@@ -261,7 +261,7 @@
 	}
 
 	if (info->should_eject) {
-#ifdef __FreeBSD__
+#if defined(__FreeBSD__) || defined(__DragonFly__)
 	    	char *argv[5] = {
 		    	"cdcontrol",
 			"-f",
Comment 2 YONETANI Tomokazu 2005-03-16 14:02:06 UTC
Created attachment 38790 [details] [review]
additional patch to add #ifdef __DragonFly__
Comment 3 Christian Kellner 2005-05-08 13:20:39 UTC
Commited to cvs. Thanks for the patch and sorry for the delay!