GNOME Bugzilla – Bug 170453
Sorting channels
Last modified: 2015-01-19 11:50:07 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/6831 "channels are now rearranged in two panels : "Playback" and "Capture". While I understand this might be improvement for people running $$$ sounds card and who use all the channels for regular professional audio work... I only need 3 channels. Master, Line-in (for the TV card), and PCM (for everything else). Problem : PCM is alone, in the Playback panel, with line-in on the other. So I keep having to switch panels everytime I want to adjust music/MP3 playback, or TV sound level, when all the channels could easily fit into one single panel and all be at hand. People who have hundreds of channels, have the possibility to enable/display only those that they need, in the Edit>Preferences, it would be great to have another option, for people who DO NOT need hundreds of channels, to put all their channels into one pane, or, more genrally, have an extra option in the preferences menu, to tell what panel they wnat a particular channel to be put in, so that people can rearragne this in the way that suits them best."
This is fairly easy to do, and sounds OK to me as an extra check-button preference. Marking for new hackers that want to enter the GNOME-media world.
Created attachment 50404 [details] screenshot I would like to play a bit with this, is this what you had in mind for the configuration dialog? Also, what should the new "merged" tab be called?
Actually, I'd rather just see this be a separate notebook page. As an extra exercise, you'll need to make the preferences a notebook. ;-). Reason is that adding random unrelated properties in top-down fashion does not look all too good. But technically, yes, something like this would be what I'm looking for.
Instead of "Merge Capture and Playback tabs", Use something like "Custom" or "Common", "All in one" or something meaningful. Because, those are not the only two tabs available.
I'd actually disagree with that. The only tabs that *are* easily mergeable are playback and capture; the others will look horrific when combined with the playback or capture tab (kind of like the old 2.8 mixer). Not to mention that the only time that people *will* actually be interested in that, is when they have capture and playback only, no others. Which brings me to another feature request, hide the notebook titles ("tabs") when there's only one available.
Wow, okay, I don't know if I can do all this... It's more difficult then totem since there is no glade here :(, but I will try to read some gtk-documentation what hopefully will make some things clear so I can try further. About that hiding, what exactly do you mean?
Created attachment 50408 [details] from
Created attachment 50409 [details] to This is how it should look, instead of the 'from' one.
Ah, I see... I will see how far I can get...
Yeah, thats true. :) So, when Playback and capture tab is merged (without tabs), what should be done when user clicks on some tracks like 'AD Input select', 'MIC Boost' in the preference dialog. Shoud a new tab be created and attached with the window in screenshot shown in attachment #50408 [details]
I don't know; I think we should just show two tabs, though. The option doesn't really make sense in this situation anyway.
Created attachment 50410 [details] [review] GUI The notebookpart in the preferences is finished, next thing to do is to save the merge setting in gconf. Is it normal to create so many variables when using a GtkNotebook?
Yes.
Created attachment 50413 [details] [review] patch (gui + loading/saving) Pfiew... gconf saving and loading is done also. It even refreshes when you manually changes the gconf key. Could you please take a look at it to make sure I'm doing it the correct way? Especially since I don't know if I have used gconf_client_get_* and gconf_client_set_* correctly (there seems to be some gconf_value_[get|set]_* also, but I don't know what I should use...)
+ gconf_client_notify_add (client, PREF_UI_MERGE, gnome_volume_control_merge_changed_callback, merge, NULL, NULL); I'd rather not see single functions per gconf key; rather, one function for all keys, so at least keep it generic. Callbacks are static, so do not need namespace, so you can easily call it cb_gconf() or so. +static void +merge_toggled_callback (GtkWidget* merge) +{ + GConfClient *client = gconf_client_get_default(); + gboolean is_set = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (merge)); + + gconf_client_set_bool (client, PREF_UI_MERGE, is_set, NULL); +} You lose a reference to the client here; try using the one we allocate in GnomeVolumeControlPreferences->clien (you can get a pointer to the preferences object here by setting it as user_data in the signal creation function, and then it'll be the second argument to this function. You alose lose a reference above in the build-up function. The GConf code is ok, so now I'll wait for the actual UI changing code. :).
Created attachment 50450 [details] [review] patch Merging of the tabs is done now. Instant refreshing of the tabs is still to be done, but I don't know how to do that. You have to restart gnome-volume-control for the tabs to get merged correctly.
Created attachment 50451 [details] screenshots are cool :)
You need to install the icons (cd data && make install). :). I'll have a look at making it instant.
I just noticed that there is another part missing in my patch, merged channels don't have a input toggle button, only a mute button... I'm not sure how to fix this.
ui changes, deferring to 2.13.x
ping? Michael, still interested in refreshing your patch?
Sorry, I don't have the time anymore... And I guess the mixer application changed a lot since 2005...
gnome-media has been obsolete since the release of GNOME 3, nearly 4 years ago. Furthermore, the gnome-volume-control program in gnome-media has been replaced by the Sound panel in gnome-control-center. The new Settings panel should not be affected by the bugs you filed, however, please make sure to file new bugs against the gnome-control-center product.