GNOME Bugzilla – Bug 170435
GtkTreeView enable-search property should only affect typeahead
Last modified: 2011-02-04 16:17:41 UTC
The default behaviour in GTK+-2.6 is to enable typeahead search in treeviews if the search column is set. While this is often the desired behaviour, there exist circumstances where typeahead interferes with other keybindings. See for example bug #169339. It should be possible to set a search column so that the Search keybinding can be used to activate the search popup dialog, but to disable typeahead search. The treeview has a property "enable-search" which should IMO do just that. It should only affect the typeahead search. If set to FALSE, the user should still be able to activate inetractive search using the Search keybinding.
Created attachment 38742 [details] [review] patch to change the treeview behaviour as requested
I am setting the milestone to 2.6.5 since we would need this change to be accepted and released in order to fix GIMP bug #169339. It would thus be good to know whether this change has a chance to be accepted.
jrb said he is ok with the change. But looking at the code, I wonder if gtk_tree_view_real_start_interactive_search is ever called with keybinding == TRUE.
Hmm, you are right. I think gtk_tree_view_start_interactive_search() is supposed to call gtk_tree_view_real_start_interactive_search() passing TRUE for keybinding.
2005-03-30 Matthias Clasen <mclasen@redhat.com> * gtk/gtktreeview.c (gtk_tree_view_real_start_interactive_search): Make enable_search control only typeahead, not C-f. (#170435, Sven Neumann) (gtk_tree_view_start_interactive_search): Pass keybinding == TRUE.