GNOME Bugzilla – Bug 170319
id3demuxbin loses tags
Last modified: 2005-03-21 17:59:15 UTC
Id3demuxbin doesn't forward tags over its pad (or loses them), which makes Totem lose ID3 tags, it seems.
Created attachment 39003 [details] [review] proposed fix Proposed fix attached. Not sure whether my usage of gst_pad_push() is kosher here - after all it's not really our pad and we are not calling it from within a chain function either. Cheers -Tim
Since you're in processing context, it should be fine, at least with our current schedulers. Feel free to apply (thanks for the fix!).
2005-03-21 Tim-Philipp Muller <tim at centricular dot net> * ext/mad/gstid3demuxbin.c: (probe_cb), (gst_id3demux_bin_init), (found_type), (gst_id3demux_bin_change_state): Catch tag events that are sent out by id3demux before typefinding has happened, and re-send them later on once typefinding has finished and id3demuxbin's ghost source pad has been created. If we don't do this, the event will never make it downstream. (fixes #170319)