After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170319 - id3demuxbin loses tags
id3demuxbin loses tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-14 13:26 UTC by Ronald Bultje
Modified: 2005-03-21 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (3.10 KB, patch)
2005-03-21 12:17 UTC, Tim-Philipp Müller
committed Details | Review

Description Ronald Bultje 2005-03-14 13:26:08 UTC
Id3demuxbin doesn't forward tags over its pad (or loses them), which makes Totem
lose ID3 tags, it seems.
Comment 1 Tim-Philipp Müller 2005-03-21 12:17:20 UTC
Created attachment 39003 [details] [review]
proposed fix

Proposed fix attached. 

Not sure whether my usage of gst_pad_push() is kosher here - after all it's not
really our pad and we are not calling it from within a chain function either.

Cheers
 -Tim
Comment 2 Ronald Bultje 2005-03-21 17:28:35 UTC
Since you're in processing context, it should be fine, at least with our current
schedulers. Feel free to apply (thanks for the fix!).
Comment 3 Tim-Philipp Müller 2005-03-21 17:59:15 UTC
2005-03-21  Tim-Philipp Muller  <tim at centricular dot net>

        * ext/mad/gstid3demuxbin.c: (probe_cb), (gst_id3demux_bin_init),
        (found_type), (gst_id3demux_bin_change_state):
          Catch tag events that are sent out by id3demux before typefinding
          has happened, and re-send them later on once typefinding has
          finished and id3demuxbin's ghost source pad has been created. If
          we don't do this, the event will never make it downstream.
          (fixes #170319)