GNOME Bugzilla – Bug 170057
FHS compliance in iPod support
Last modified: 2005-09-25 08:56:28 UTC
Hi, I've turned iPod support in Rhythmbox 0.8 for Debian[1]. Recently, in Debian bug <http://bugs.debian.org/298915>, I was told Rhythmbox could be made more FHS compliant if it used /media/ipod as the default mount path for the iPod, instead of the current hardcoded path: /mnt/ipod. I noticed the 0.8 branch also checks for a qahog iPod path. As far as I understand it, it seems qahog is an unreleased GNOME module which has its last checkins in march 2004, and Rhythmbox 0.9 seems to use a whole new system based on GnomeVFSVolumeMonitor, which is itself based on libhal. Is it safe to assume that the FHS compliance issue has been resolved in 0.9 since no hardcoded path is involved? Could you please change /mnt to /media in 0.8 branch (or support both)? (I will patch the Debian package to match your changes to not diverge too much.) Regards, [1] I know the iPod support code might be better in the 0.9 branch, but I have to stick with 0.8 for now as 0.9 is unreleased and depends of recent GNOME libraries not yet in Debian. PS: may I suggest an iPod Component for iPod bugs?
Created attachment 38781 [details] [review] Patch to use GnomeVFSVolumeMonitor and (optionally) hal to find the iPod mount point in the 0.8 branch Probably much better than a quick and dirty hack to look for /media/ipod in addition to /mnt/ipod (and needed by the ubuntu guys)
That's an absolutely cool patch, thanks! Sadly, it will need some more time for me to test as I'll have to grab an iPod and switch to HAL and switch to udev -- both not the default in Debian. (Or I might upload pacakges to experimental for people to test.) Again, thanks for the patch.
Neither HAL nor udev are needed for this patch. If hal is present, when it detects a new mount, it goes to check the device manufacturer in the usb or firewire properties for the device which was mounted, if hal isn't there, it just checks for the presence of a specific file to detect whether the new device is an ipod or not. So things should work when hal isn't installed and rhythmbox is compiled without rhythmbox installed.
That's great news, I'll just have to get my hands on an iPod in the next days, then! If anyone subscribed to the Rhythmbox BTS wants to test Rhythmbox pacakges with this patch, there are temporarily here: <http://joule.via.ecp.fr/~lool/debian/rhythmbox/0.8.8-7/> Thanks for the clarification.
Christophe, is this patch in CVS?
Nope, I never came around to commit it.
Works nice in Debian, and I've tested it and seen tested it with iPod and iPod minor if that matters.
If this patch makes things work better with iPods by all means let's get it in. One random comment: No need for #ifdef HAL; we should just require HAL unconditionally.
The issue is that RB doesn't compile against HAL >= 0.5. I think there is a patch for that somewhere in bugzilla, but it then doesn't compile against earlier versions - no-one got around to making it support both. Bug 310017 has the patch for HAL >= 0.5
These changes are already in cvs. Closing
Set it FIXED for real