After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 169979 - gnome-panel crashes when opening properties dialog
gnome-panel crashes when opening properties dialog
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: file-chooser
2.10.x
Other other
: High critical
: future
Assigned To: Alexander Larsson
Panel Maintainers
: 170594 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-11 16:36 UTC by vivien.malerba
Modified: 2005-03-27 12:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
libgnomeui patch (890 bytes, patch)
2005-03-21 14:11 UTC, Vincent Untz 		committed Details | Review

Description vivien.malerba 2005-03-11 16:36:52 UTC 
Distribution: White Box Enterprise Linux release 3.0 (Liberation)
Package: gnome-panel
Severity: critical
Version: GNOME2.10.0 2.10.x
Gnome-Distributor: GARNOME
Synopsis: gnome-panel crashes when opening properties dialog
Bugzilla-Product: gnome-panel
Bugzilla-Component: Panel
Bugzilla-Version: 2.10.x
BugBuddy-GnomeVersion: 2.0 (2.10.0)
Description:
Description of the crash:
The gnome panel crashes when opening properties dialog

Steps to reproduce the crash:
1. on a panel, right click and select "Properties"
2.
3.

Expected Results:
Properties are shown

How often does this happen?
Everytime

Additional Information:
Gnome 2.10 compiled on a RHAS3.0 using garnome. There are some other 
problems with applications crashing, so I chose this one as it is the 
easiest to reproduce.

I have GTK 2.6.4 installed.

Debugging Information:

Backtrace was generated from '/local/G10/bin/gnome-panel'

(no debugging symbols found)...Using host libthread_db library
"/lib/tls/libthread_db.so.1".
(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...[Thread
debugging using libthread_db enabled]
[New Thread 1087012064 (LWP 12104)]
[New Thread 1093114800 (LWP 26706)]
[New Thread 1092664240 (LWP 12140)]

0x40000c32 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2

+ Trace 56718

Thread 1 (Thread 1087012064 (LWP 12104))

  • #0 _dl_sysinfo_int80
    from /lib/ld-linux.so.2
  • #1 __waitpid_nocancel
    from /lib/tls/libpthread.so.0
  • #2 libgnomeui_segv_handle
    from /local/G10/lib/libgnomeui-2.so.0
  • #3 <signal handler called>
  • #4 _gtk_sequence_ptr_get_data
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #5 gtk_list_store_get_value
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #6 gtk_tree_model_get_value
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #7 gtk_tree_model_filter_get_value
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #8 gtk_tree_model_get_value
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #9 gtk_tree_model_get_valist
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #10 gtk_tree_model_get
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #11 update_combo_box
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #12 gtk_file_chooser_button_constructor
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #13 g_object_newv
    from /local/G10/lib/libgobject-2.0.so.0
  • #14 glade_standard_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #15 glade_xml_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #16 glade_standard_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #17 glade_xml_set_common_params
    from /local/G10/lib/libglade-2.0.so.0
  • #18 glade_xml_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #19 glade_standard_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #20 glade_xml_set_common_params
    from /local/G10/lib/libglade-2.0.so.0
  • #21 glade_xml_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #22 glade_standard_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #23 glade_xml_set_common_params
    from /local/G10/lib/libglade-2.0.so.0
  • #24 glade_xml_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #25 notebook_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #26 glade_xml_set_common_params
    from /local/G10/lib/libglade-2.0.so.0
  • #27 glade_xml_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #28 glade_standard_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #29 glade_xml_set_common_params
    from /local/G10/lib/libglade-2.0.so.0
  • #30 glade_xml_handle_internal_child
    from /local/G10/lib/libglade-2.0.so.0
  • #31 glade_standard_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #32 gtk_dialog_build_children
    from /local/G10/lib/libglade-2.0.so.0
  • #33 glade_xml_set_common_params
    from /local/G10/lib/libglade-2.0.so.0
  • #34 glade_xml_build_widget
    from /local/G10/lib/libglade-2.0.so.0
  • #35 glade_xml_build_interface
    from /local/G10/lib/libglade-2.0.so.0
  • #36 glade_xml_construct
    from /local/G10/lib/libglade-2.0.so.0
  • #37 glade_xml_new
    from /local/G10/lib/libglade-2.0.so.0
  • #38 panel_properties_dialog_present
  • #39 g_cclosure_marshal_VOID__VOID
    from /local/G10/lib/libgobject-2.0.so.0
  • #40 g_closure_invoke
    from /local/G10/lib/libgobject-2.0.so.0
  • #41 signal_emit_unlocked_R
    from /local/G10/lib/libgobject-2.0.so.0
  • #42 g_signal_emit_valist
    from /local/G10/lib/libgobject-2.0.so.0
  • #43 g_signal_emit
    from /local/G10/lib/libgobject-2.0.so.0
  • #44 gtk_widget_activate
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #45 gtk_menu_shell_activate_item
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #46 gtk_menu_shell_button_release
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #47 gtk_menu_button_release
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #48 _gtk_marshal_BOOLEAN__BOXED
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #49 g_type_class_meta_marshal
    from /local/G10/lib/libgobject-2.0.so.0
  • #50 g_closure_invoke
    from /local/G10/lib/libgobject-2.0.so.0
  • #51 signal_emit_unlocked_R
    from /local/G10/lib/libgobject-2.0.so.0
  • #52 g_signal_emit_valist
    from /local/G10/lib/libgobject-2.0.so.0
  • #53 g_signal_emit
    from /local/G10/lib/libgobject-2.0.so.0
  • #54 gtk_widget_event_internal
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #55 gtk_propagate_event
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #56 gtk_main_do_event
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #57 gdk_event_dispatch
    from /local/G10/lib/libgdk-x11-2.0.so.0
  • #58 g_main_dispatch
    from /local/G10/lib/libglib-2.0.so.0
  • #59 g_main_context_dispatch
    from /local/G10/lib/libglib-2.0.so.0
  • #60 g_main_context_iterate
    from /local/G10/lib/libglib-2.0.so.0
  • #61 g_main_loop_run
    from /local/G10/lib/libglib-2.0.so.0
  • #62 gtk_main
    from /local/G10/lib/libgtk-x11-2.0.so.0
  • #63 main
  • #0 _dl_sysinfo_int80
    from /lib/ld-linux.so.2 




------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-03-11 11:36 -------


Unknown platform unknown. Setting to default platform "Other".
Unknown milestone "unknown" in product "gnome-panel".
   Setting to default milestone for this product, '---'
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here, unknown@bugzilla.gnome.org.
   Previous reporter was vivien.malerba@aviation-civile.gouv.fr.
Setting to default status "UNCONFIRMED".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Comment 1 Elijah Newren 2005-03-11 17:18:11 UTC 
Thanks for the bug report.  This appears to be a unique stack trace, according
to the simple-dup-finder.
Comment 2 Jeremy Wise 2005-03-12 16:43:51 UTC 
I built Garnome 2.10.0 on FC3 and have this same problem.  I cleaned out all of
my gnome settings in my home dir, restarted, and I get two very empty panels
now.  Trying to pull up the properties dialog crashes every single time, so I
can't configure anything concerning my useless panels.
Comment 3 Christian Kirbach 2005-03-12 17:59:49 UTC 
Confirmed for Garnome 2.10.0 on Debian testing.
Comment 4 malerba 2005-03-14 08:35:19 UTC 
I rebuilt and re-installed gtk+ and the gnome-panel removing the --disable-debug
configure option from the gar.gnome.mk file in garnome, and everything is OK
now. I think it's a GTK warning (like g_return_if_fail()) which was not applied
because of the --disable-debug flag.

Maybe garnome should always build GTK+ and gnome-panel (and nautilus?) without
that flag because they are core parts of the gnome desktop?
Comment 5 Christian Kirbach 2005-03-15 13:25:20 UTC 
Hmm rebuilding without the --disable-debug flag in the gar.gnome.mk file as 
described before did not remedy for me. I rebuilt gtk+, libwnck and the panel.

I removed the cookies/ directory and ran make install again.
Should have overwritten the old stuff if I am not mistaken.
Comment 6 fly 2005-03-16 10:46:17 UTC 
Same problem with garnome-2.10 on Slackware 10.0 :(
Comment 7 Christian Kirbach 2005-03-16 13:43:11 UTC 
According to #garnome these issues will be fixed with the next GARNOME release 
that is scheduled very soon.
Comment 8 Christian Kirbach 2005-03-17 19:11:44 UTC 
*** Bug 170594 has been marked as a duplicate of this bug. ***
Comment 9 Martin Pagh Goodwin 2005-03-19 20:20:58 UTC 
Bug 170346 seems very similar
Comment 10 Christian Kirbach 2005-03-20 15:56:12 UTC 
No it is different Martin.
Comment 11 Vincent Untz 2005-03-21 14:11:59 UTC 
Created attachment 39009 [details] [review]
libgnomeui patch
Comment 12 Vincent Untz 2005-03-21 14:15:01 UTC 
Wow. I'm away for a few days and I get lots of bugzilla mails...

Okay, I looked at this and it's a bug in the libgnomeui backend for the file
chooser: gnome_vfs_get_uri_from_local_path() doesn't appreciate strings that are
empty.

We could argue that it's a bug in gnome-vfs when compiled with --disable-debug,
but we'll first try to patch libgnomeui.
Comment 13 Vincent Untz 2005-03-21 14:15:50 UTC 
Adding Federico so he can review the patch.
Comment 14 Federico Mena Quintero 2005-03-22 00:03:17 UTC 
The question is, why did it get an empty filename?

There's already a check for NULL in gtk_file_system_filename_to_path(), so the
actual implementation doesn't need to check for it.
Comment 15 Federico Mena Quintero 2005-03-22 00:25:54 UTC 
The patch is good to go in if you remove the check for NULL --- just leave the
check for an empty string.

I still wonder why it got an empty string in the first place.  That may be a bug
in the caller.
Comment 16 Vincent Untz 2005-03-26 13:53:26 UTC 
Federico: I think this is what's happening (just a guess, though):

 1. the panel properties dialog is built, with a GtkFileChooserButton
 2. we do gtk_file_chooser_set_filename("") because there's no filename for the
b ackground
 3. gtk_file_chooser_select_filename() is called with ""
 4. warning/crash

I'll fix the code in the panel too.
Comment 17 Christian Kirbach 2005-03-27 12:37:16 UTC 
This has been fixed in Garnome 2.10.0.1

I wonder what patch they used...
Comment 18 Vincent Untz 2005-03-27 12:43:26 UTC 
Christian: they don't compile with --disable-warning now, IIRC.