After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 169680 - esddsp crashes artsd
esddsp crashes artsd
Status: RESOLVED FIXED
Product: esound
Classification: Deprecated
Component: general
0.2.31
Other Linux
: High major
: ---
Assigned To: Esound Maintainers
Esound Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-09 02:08 UTC by Fabian Franz
Modified: 2005-05-26 00:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
FIx wrong handling of SNDCTL_DSP_GETISPACE (1.42 KB, patch)
2005-03-09 02:11 UTC, Fabian Franz
none Details | Review
Fix wrong handling of SNDCTL_DSP_GET[IO]SPACE (correct comments) (1.44 KB, patch)
2005-03-09 23:55 UTC, Fabian Franz
none Details | Review

Description Fabian Franz 2005-03-09 02:08:05 UTC
Hi,

esddsp crashes artsd, because the OSS emulation is done wrong in the
SNDCTL_DSP_GETISPACE ioctl.

A patch based on the specification of 4-Front technologies will follow.
Comment 1 Fabian Franz 2005-03-09 02:11:17 UTC
Created attachment 38443 [details] [review]
FIx wrong handling of SNDCTL_DSP_GETISPACE

Hi,

the patch fixes SNDCTL_DSP_GET[IO]SPACE.

I found it while trying to run artsd through esddsp, but it might also fix
other applications.

Please test and apply, if tests were successful :-).

cu

Fabian
Comment 2 Kjartan Maraas 2005-03-09 14:29:10 UTC
Thanks for the patch. I can't comment on the correctness of the patch since I
don't know the code or the spec, but please use /* */ style comments not C++ ones. 
Comment 3 Fabian Franz 2005-03-09 23:55:20 UTC
Created attachment 38479 [details] [review]
Fix wrong handling of SNDCTL_DSP_GET[IO]SPACE (correct comments)

Hi,

the patch fixes SNDCTL_DSP_GET[IO]SPACE.

I found it while trying to run artsd through esddsp, but it might also fix
other applications.

Please test and apply, if tests were successful :-).

cu

Fabian

PS: Now with correct markup for the comments.
Comment 4 David Schleef 2005-05-26 00:41:55 UTC
Applied, thanks.