After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 169629 - [theoraenc] sharpness property
[theoraenc] sharpness property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-08 17:53 UTC by Gergely Nagy
Modified: 2005-03-12 22:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to expose the sharpness parameter (2.65 KB, patch)
2005-03-08 17:55 UTC, Gergely Nagy 		none Details | Review
Updated patch (2.77 KB, patch)
2005-03-11 23:00 UTC, Gergely Nagy 		none Details | Review

Description Gergely Nagy 2005-03-08 17:53:20 UTC 
The `sharpness' parameter can come very handy at times, but is not exported by
theoraenc.

(See, for example: http://lists.xiph.org/pipermail/theora-dev/2004-July/002268.html)

Patch to expose this parameter will be attached shortly.
Comment 1 Gergely Nagy 2005-03-08 17:55:35 UTC 
Created attachment 38423 [details] [review]
Patch to expose the sharpness parameter
Comment 2 Ronald Bultje 2005-03-10 17:11:50 UTC 
Why is it a guint8 and not a gint?...
Comment 3 Gergely Nagy 2005-03-11 09:55:23 UTC 
Because it's in the 0-2 range, and guint8 is the smallest type that can hold it.
That's all. It could just as well be gint.
Comment 4 Ronald Bultje 2005-03-11 12:23:39 UTC 
Yes, I'd prefer a gint. guint8 should only be used for very specific reasons
(e.g. becuse you're using an array and need per-byte access), since guint8 is
actually slower than gint.
Comment 5 Gergely Nagy 2005-03-11 12:44:42 UTC 
I see. Should I submit an updated patch, just to change that one line?
Comment 6 Ronald Bultje 2005-03-11 12:52:54 UTC 
Yes, because I'm a lazy ass.
Comment 7 Gergely Nagy 2005-03-11 23:00:26 UTC 
Created attachment 38576 [details] [review]
Updated patch

Did the guint8->gint change. Otherwise the patch is exactly the same as before.
Comment 8 Ronald Bultje 2005-03-12 22:44:16 UTC 
applied, thanks.