GNOME Bugzilla – Bug 169622
(Re)add support for alpha blended xft rendering
Last modified: 2005-06-21 16:26:14 UTC
The alpha component of xft colors are ignored since pango 1.8.0, here is a patch to unignore them again. The patch is possibly not correct according to owen on irc, but here it goes. Current version of the patch tries to reset the alpha, but does in the wrong place, only the first run gets the correct alpha. 17:13:46 <owen> you need to restore the alpha to 0xffff after rendering 17:28:01 <owen> Mikachu: Maybe the resetting isn't needed at all, I'd have to study the code a bit more (file a bug, attach your current version). We don't reset the color ... not sure if that is intentional or a bug itself. 17:28:32 <owen> But definitely pango_xft_renderer_set_default_color() needs to set the alpha to 0xffff if you don't reset
Created attachment 38421 [details] [review] second version of the patch
Created attachment 48107 [details] [review] Patch I'm applying Here's what I'm applying. What I meant about restoring the alpha was after the rendering was entirely done, not after rendering just one piece.
2005-06-21 Owen Taylor <otaylor@redhat.com> * pango/pangoxft-render.c (get_renderer): Go back to honoring alpha in the XftColor passed in; it was a 1.6 => 1.8 regression. (#169622, based on a patch from Mikael Magnusson)
Thanks.