After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 169333 - [pngdec, pngenc] Stride problems
[pngdec, pngenc] Stride problems
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-05 21:35 UTC by Gergely Nagy
Modified: 2005-03-10 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the problem (1.65 KB, patch)
2005-03-05 21:57 UTC, Gergely Nagy
none Details | Review
Fixed patch... (1.67 KB, patch)
2005-03-05 22:00 UTC, Gergely Nagy
none Details | Review

Description Gergely Nagy 2005-03-05 21:35:13 UTC
pngdec knows nothing about strides. Just try pngdec ! ffmpegcolorspace !
ximagesink with an image that has an odd width, and you'll see.

Patch coming soon...
Comment 1 Gergely Nagy 2005-03-05 21:48:47 UTC
Same goes for pngenc. I'm testing a possible patch, will submit in a few minutes.
Comment 2 Gergely Nagy 2005-03-05 21:57:48 UTC
Created attachment 38316 [details] [review]
Patch fixing the problem

This patch makes png* round up widths so that they are a multiple of four.
Tested with 24 and 32 bit images, and the patch fixes the elements in the case
of images it broke on before, and those that worked before, work after the
patch too.
Comment 3 Gergely Nagy 2005-03-05 22:00:19 UTC
Created attachment 38317 [details] [review]
Fixed patch...

*sigh*

The second part of the previous patch is obviously wrong, I diffed against the
wrong tree. Fixed now.

Sorry for the noise.
Comment 4 Ronald Bultje 2005-03-10 16:57:43 UTC
applied, thanks once more!