GNOME Bugzilla – Bug 169220
different icons in window list and window selector applets
Last modified: 2005-06-21 17:55:06 UTC
If you open a folder window with a recent nautilus, the icon shown in the window list applet is a crisp, small-res icon. However,the icon shown in the window selector applet is a blurry, scaled-down hi-res icon. I think the window list applet has the right behavior. The window selector should follow it. For some reason, I can only trigger this bug with nautilus windows. All other icon appear fine in both applets. The bug is obvious since this commit in nautilus : 2005-02-22 Alexander Larsson <alexl@redhat.com> * src/nautilus-window.c: (nautilus_window_update_icon): Use names and not pixbufs for the window icons. This means the icons of the best size are used. Patch from Jaap Haitsma <jaap@haitsma.org> Cc'ing Vincent for his incredible insights ;-)
Created attachment 38263 [details] screenshot showing the different icons
I was about to re-submit this bug... Here is the one-line patch to fix it, it makes tasklist.c and selector.c use the same method to grab the window's icon. As the window selector applet icon does not scale to follow the applet size (like the window list does), the mini icon is better : Index: libwnck/selector.c =================================================================== RCS file: /cvs/gnome/libwnck/libwnck/selector.c,v retrieving revision 1.6 diff -u -r1.6 selector.c --- libwnck/selector.c 16 Jun 2005 17:32:36 -0000 1.6 +++ libwnck/selector.c 21 Jun 2005 16:56:33 -0000 @@ -158,7 +158,7 @@ freeme2 = NULL; if (window) - pixbuf = wnck_window_get_icon (window); + pixbuf = wnck_window_get_mini_icon (window); if (!pixbuf) pixbuf = wnck_selector_get_default_window_icon ();
Vincent: please commit this big patch ;-)
It's not the size that counts ;) Committed.