After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168728 - [v4lsrc] Support for v4l radio (patch included)
[v4lsrc] Support for v4l radio (patch included)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal enhancement
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-28 06:19 UTC by Nickolay V. Shmyrev
Modified: 2005-03-31 21:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tar.gz with sources and patch (8.14 KB, application/gzip)
2005-02-28 06:20 UTC, Nickolay V. Shmyrev
Details

Description Nickolay V. Shmyrev 2005-02-28 06:19:23 UTC
It would be nice to include the following plugin
Comment 1 Nickolay V. Shmyrev 2005-02-28 06:20:01 UTC
Created attachment 38036 [details]
tar.gz with sources and patch
Comment 2 Nickolay V. Shmyrev 2005-02-28 06:21:25 UTC
Example of it's usage

gst-launch v4lradio frequency=103700000 \( osssrc \) ! osssink
Comment 3 Ronald Bultje 2005-02-28 18:15:27 UTC
Cool! I'll look at this sometime soon.
Comment 4 Ronald Bultje 2005-03-31 18:00:57 UTC
This patch is pretty good, I have to admit. I'm surprised you were able to
integrate the tuner interface so easily. Here's a few small comments:
* I'm ok with putting the plugin in its own dir (sys/v4lradio/), but I'd like
its configure stuff to be shared with v4l. So in Makefile.am, use: if:
if USE_V4L
v4ldir = v4l v4lradio
else
v4ldir=
fi
I hope you understand why: it's easier to maintain.
* Is it possible to autodetect which oss/alsa device belongs with it? It may be
slightly painful for applications to auto-support this. I'm not very familiar
with the radio part of v4l, so it's kinda hard to say for me myself.
* A sample application would be sooooooooooooooo cool, basically GNOME radio.
Has to be possible in ~100 lines of python with this element. do you have
something like that?

Thanks! I'll try to integrate this one of the next few days.
Comment 5 Nickolay V. Shmyrev 2005-03-31 18:26:54 UTC
Thank you, just because you've done most part of work.

> I hope you understand why: it's easier to maintain.

No problem, it's even better.

>Is it possible to autodetect which oss/alsa device belongs with it? It may be
slightly painful for applications to auto-support this. I'm not very familiar
with the radio part of v4l, so it's kinda hard to say for me myself.

Well, I think it can be future work in this area. There are some things left
unimplemented, like stereo support and searching. But if there would be start,
there will be no problem to develop it further. Also it would be nice for
container to detect mixer interface in child and set up record source apropriately.

> A sample application would be sooooooooooooooo cool, basically GNOME radio.
Has to be possible in ~100 lines of python with this element. do you have
something like that?

Bug 168735 has patch that adds v4l radio funtionality for rhythmbox with
v4lradio plugin. I hope it can be considered like sample app. Hope, it will be
reviewed and applied sometime.




Comment 6 Ronald Bultje 2005-03-31 18:41:16 UTC
Wow, yes, Rhythmbox is perfect as a sample app, much better even. I'd suggest
adding a small pointer to Rhythmbox in the README in the video4linux sourcedir,
for those wanting to write their own. I'll do that myself. ;).

I'll try to implement this sometime soon, it's well-written and well, we'll add
device detection later on or so. You're correct there.
Comment 7 Ronald Bultje 2005-03-31 21:48:25 UTC
It's committed, thanks for the initial work, great job! Feel free to do any of
the stuff outlines above, but this is great already.