GNOME Bugzilla – Bug 168703
[API] Add gst_index_add_associationv() to gstindex.h
Last modified: 2006-01-18 09:45:09 UTC
gst_index_add_associationv() is currently declared non-static in gstindex.c but is not prototyped in gstindex.h. Since it's properly documented and necessary for language bindings, I think gst_index_add_associationv() should be added to gstindex.h.
Indeed. Please provide patch, if you don't mind.
Created attachment 38032 [details] [review] Adding gst_index_add_associationv() gstindex.h Patch against HEAD of anoncvs.
Aren't *v functions usually varargs-based?
*_valist() is for va_list-based functions. *v() is for vector-based, like g_strdupv() or writev().
I misread a few things, sorry. Patch applied.
Why was gst_index_add_associationv() removed again in 0.9?
Probably because 0.9 was branched before this was applied, and didn't get merged up? A mistake most likely. Can you provide a new patch against HEAD?
Created attachment 57548 [details] [review] Updated patch
In the future two things will help your patches get applied: 1) Make sure they are up to date. You diffed against version 1.17 of that file, but the patch fails to apply to current CVS has version 1.24. 2) Include a ChangeLog entry. I'll go ahead and manually apply.
Hm, my bad, must have downloaded the wrong patch ;-) 2006-01-18 Andy Wingo <wingo@pobox.com> * gst/gstindex.h (gst_index_add_associationv): Add to header. The symbol was exported before, it appears this was just an oversight. Fixes #168703. Patch by: Torsten Schoenfeld <kaffeetisch at gmx.de> * gst/gstindex.c (gst_index_add_associationv): Changed int in prototype to gint. OK since this prototype was not in the header.