After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168691 - [PATCH]cddb-slave2 doesn't handle multiple exact matches (cddb code 210)
[PATCH]cddb-slave2 doesn't handle multiple exact matches (cddb code 210)
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: CDDBSlave2
2.8.x
Other All
: High normal
: 2.10.1
Assigned To: gnome media maintainers
gnome media maintainers
: 167570 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-02-27 20:25 UTC by Lorenzo Colitti
Modified: 2005-03-20 13:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
one-line fix (337 bytes, patch)
2005-02-27 20:35 UTC, Lorenzo Colitti 		none Details | Review

Description Lorenzo Colitti 2005-02-27 20:25:17 UTC 
Please describe the problem:
If I use gnome-cd to play a CD which has multiple exact matches in the CDDB
database, gnome-cd does not show the name of the CD. This is because cddb-slave2
does not handle the "multiple exact matches" response (code 210 in the CDDB
protocol). It handles the "multiple inexact matches" response (code 211) fine
and correctly prompts the user to choose.

Examples of discs affected are Selling England by the Pound (Genesis), Fugazi
(Marillion), etc.

Steps to reproduce:
1. Load gnome-cd
2. Insert CD with multiple matches


Actual results:
gnome-cd displays "Unknown Artist" and "Unknown Album"

Expected results:
gnome-cd should display the correct artist and album

Does this happen every time?
Yes

Other information:
Comment 1 Lorenzo Colitti 2005-02-27 20:35:17 UTC 
Created attachment 38020 [details] [review]
one-line fix

This fixes the problem for me.
Now cddb-slave2 correctly prompts the user if there are multiple exact matches.
Comment 2 Lorenzo Colitti 2005-03-04 15:42:38 UTC 
Setting PATCH keyword and priority to high since there is a patch.
Comment 3 Ronald Bultje 2005-03-04 16:11:37 UTC 
Hi,

since this is not a crasher, I'd vote for delaying this until 2.11. the patch
looks good, thanks.
Comment 4 Christian Kirbach 2005-03-04 17:11:46 UTC 
Smart patch that can hardly break anything. :)

why not merge it soon?
Comment 5 Ronald Bultje 2005-03-04 19:00:06 UTC 
I tend to break freezes a lot already... We're deep in the GNOME 2.10 cycle,
past the complete code freeze. I'd rather delay it until after the freeze, i.e.
GNOME 2.10.1.
Comment 6 Ronald Bultje 2005-03-20 12:36:46 UTC 
Applied for 2.10.1.
Comment 7 Ronald Bultje 2005-03-20 13:48:09 UTC 
*** Bug 167570 has been marked as a duplicate of this bug. ***