After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168445 - LegacyDir vs. OnlyUnallocated
LegacyDir vs. OnlyUnallocated
Status: RESOLVED FIXED
Product: gnome-menus
Classification: Core
Component: general
2.9.x
Other Linux
: High normal
: ---
Assigned To: gnome-menus dummy account
gnome-menus dummy account
Depends on:
Blocks:
 
 
Reported: 2005-02-24 20:49 UTC by Chris Lahey
Modified: 2005-03-08 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix-legacy-entries-not-marked-as-allocated.patch (3.23 KB, patch)
2005-03-01 18:28 UTC, Mark McLoughlin 		none Details | Review

Description Chris Lahey 2005-02-24 20:49:15 UTC 
Having a menu item in a LegacyDir doesn't cause it to be hidden in an
"OnlyUnallocated" menu.
Comment 1 Mark McLoughlin 2005-03-01 18:28:34 UTC 
Created attachment 38114 [details] [review]
fix-legacy-entries-not-marked-as-allocated.patch

Fix for this one. Testing appreciated.
Comment 2 Chris Lahey 2005-03-02 21:55:47 UTC 
This seems to work fine.  This and the last one help a considerable amount.
Comment 3 Mark McLoughlin 2005-03-08 17:40:15 UTC 
Will be in 2.10.1

2005-03-08  Mark McLoughlin  <mark@skynet.ie>

        Fix for bug #168445 - menu items in LegacyDirs don't
        get marked as allocated.

        * libmenu/menu-tree.c:
        (mark_allocated_foreach): kill.
        (process_layout), (process_only_unallocated),
        (menu_tree_build_from_layout): store the list of allocated
        entires in a DesktopEntrySet so we can look up an entry
        using its file ID rather than with a straight pointer
        comparison. Entries in LegacyDirs are copies of the original
        enties, so the pointer comparison doesn't work.