GNOME Bugzilla – Bug 168357
[PATCH] Add FreeBSD wireless support to gnome-netstatus
Last modified: 2005-03-14 14:38:26 UTC
Please describe the problem: The attached patch fixes some build issues on FreeBSD as well as adds support for all current wireless interfaces under FreeBSD. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 37878 [details] [review] Add FreeBSD wireless support to gnome-netstatus
Comment on attachment 37878 [details] [review] Add FreeBSD wireless support to gnome-netstatus Patch looks good to me. Thanks. The only problem I see is that it doesn't follow the same coding style as the rest of the code. 2 spaces for indentation, braces on their own line etc. etc. We're in code freeze now, but feel free to commit after 2.10.0 has been released.
Created attachment 38191 [details] [review] Same patch using existing coding style
Okay, I think my latest patch is more inline with the pre-existing coding style. However, I don't have commit access, so someone will have to commit this for me once the freeze lifts. Thanks.
Thanks Joe, just committed this on HEAD and gnome-2-10: 2005-03-14 Mark McLoughlin <mark@skynet.ie> Patch from Joe Marcus Clarke <marcus@freebsd.org> to implement FreeBSD support for wireless details. Bug #168357. Same as the patch committed on HEAD, except the newly added error messages aren't marked for translation. * src/netstatus-iface.c: include some missing headers. * src/netstatus-sysdeps.c: (netstatus_sysdeps_read_iface_wireless_details): Implement FreeBSD version.