Created attachment 37861 [details] [review]
patch to add jrtp plugin

Thank you for submitting a patch.
Developers will likely look into it.

bug_severity should be set to ENHANCEMENT.

Hi,

- jrtplib_c.h contains a #ifdef __cplusplus, please use G_BEGIN_DECLS.
- A lot of properties (their accessors in structs_ start with _. Why?
- how do you use the datadec/dataenc. In a series with the source/sink? So like
datasource ! datadec ! <other_gst_element> and <other_gst_element> ! dataenc !
datasink?
- Can you implement the URI interface so it works in Totem, too?

Thanks for the patch, it looks great although I don't know too much about RTP to
be honest.

We have been having 'generic' rtp elements around but we then adondoned this
practice, since there are *almost* as many ways of rtp encapsulation as are data
format/codec out there.

We're currently reworking this code. the general schema which we are aiming for is:

RTP sink/source - these have pads with caps as mimetype
application/x-rtp-transport (or somesuch) that includes an GstEvent based
communictaion of packetisation information. RTP stream frequency is taken from a
'rate' parameter.

RTP Payload enc/decoders - these can take an encoded stream and packetise them
fro RTP as per the relevent RFC, emitting on pads with
application/x-rtp-transport capability

Obviously in a number of cases the payload enc/decoder may well actually be part
of the media codec, and cap nego could be used.

ideas/criticsm gladly received.

Work seems to be going on in CVS and IRC. Closing this bug for now, open a new
one for new issues.