After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168117 - [PATCH] better transparency support for the window list applet
[PATCH] better transparency support for the window list applet
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: window list
git master
Other All
: High normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 73744 (view as bug list)
Depends on: 167932
Blocks:
 
 
Reported: 2005-02-22 06:34 UTC by Allison Karlitskaya (desrt)
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch (724 bytes, patch)
2005-02-22 06:35 UTC, Allison Karlitskaya (desrt)
none Details | Review
updated. (921 bytes, patch)
2005-02-25 18:45 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2005-02-22 06:34:42 UTC
As per discussion in Bug 167932 this is a small patch to the window list applet
to make it use the wnck_tasklist_set_button_relief() function.

The semantics are:
  For "no background (system theme)" panels, everything remains the same.
  For pixmap/colour/transparent panels, the button relief is removed.
Comment 1 Allison Karlitskaya (desrt) 2005-02-22 06:35:07 UTC
Created attachment 37764 [details] [review]
the patch
Comment 2 Vincent Untz 2005-02-25 17:58:44 UTC
*** Bug 73744 has been marked as a duplicate of this bug. ***
Comment 3 Vincent Untz 2005-02-25 18:00:50 UTC
Ryan: I'd prefer if you could modify your patch to use a switch, so it's the
same code as in workspace-switcher.c. I find it's more readable with the switch ;-)
Comment 4 Allison Karlitskaya (desrt) 2005-02-25 18:45:37 UTC
Created attachment 37943 [details] [review]
updated.

updated patch, as per request.

there are some lines >80 chars.  i couldn't come up with a reasonable way to
avoid it so i went by the convention used elsewhere in the same file.
Comment 5 Allison Karlitskaya (desrt) 2005-02-25 18:47:25 UTC
Pending the approval of bug 167932 by the release team is this one also OK?
Comment 6 Vincent Untz 2005-02-25 19:18:48 UTC
As I said in bug #167932, it might be better to enable this only for pixmap
backgrounds if there's approval for the other patch.
Comment 7 Allison Karlitskaya (desrt) 2005-02-25 19:38:00 UTC
OK.  I'll write the release team and ask them what they think.
Comment 8 Vincent Untz 2005-03-01 16:34:15 UTC
Seems it will wait for 2.12.
Comment 9 Allison Karlitskaya (desrt) 2005-06-03 17:27:11 UTC
Can I commit these to HEAD?
Comment 10 Vincent Noel 2005-08-02 16:38:25 UTC
Will this be in for 2.12 ?
The relevant API has been added to libwnck in bug #167932.
Comment 11 Sebastien Bacher 2005-10-01 13:13:27 UTC
maybe that could go for GNOME 2.12.1?
Comment 12 Allison Karlitskaya (desrt) 2005-10-01 14:57:44 UTC
+1 :)
Comment 13 Vincent Untz 2005-10-03 06:51:15 UTC
Committed.
Ryan: something must have changed somewhere since it only works for plain color
backgrounds and not for image backgrounds. Could you take a look at it and open
a bug against the right component (probably lubwnck or GTK+)?

Thanks
Comment 14 Vincent Untz 2005-10-03 07:17:48 UTC
Ah, it doesn't work with Glider but works with Simple. Might be related to bug
#165608
Comment 15 Allison Karlitskaya (desrt) 2005-10-12 02:49:04 UTC
I've never set pixmaps for my panels -- always just use solidcolour and turn the
transparency way up.  I just tried to set a pixmap background and the results
were fantastically bad.  The entire panel is visually corrupted -- not just the
applet.

What's the story here?