After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167998 - Handle libwnck API changes
Handle libwnck API changes
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: Immediate normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-20 23:46 UTC by Elijah Newren
Modified: 2005-02-21 08:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Use event->time to pass to wnck_workspace_activate (645 bytes, patch)
2005-02-20 23:47 UTC, Elijah Newren 		accepted-commit_now Details | Review
Update configure.in to depend on libwnck 2.9.92 (1.05 KB, patch)
2005-02-21 08:23 UTC, Elijah Newren 		none Details | Review

Description Elijah Newren 2005-02-20 23:46:48 UTC 
Due to both bug 128380 and bug 161361 (and other issues mentioned there in
general), libwnck needed some changes which included adding a timestamp
parameter to two functions (well, more than that when you count the propagation
to other functions that entailed; the full libwnck patch can be seen in bug
161361).  Anyway, gnome-panel and gok both appear to be affected.  I will attach
the needed gnome-panel patch in a minute.
Comment 1 Elijah Newren 2005-02-20 23:47:45 UTC 
Created attachment 37728 [details] [review]
Use event->time to pass to wnck_workspace_activate
Comment 2 Elijah Newren 2005-02-21 00:28:14 UTC 
Hmm... now that I file this I realize I probably should have put the libwnck
patch that caused the need for this gnome-panel patch in a separate bug report
instead of in bug 161361 since you two are maintainers now too; I just put it in
a metacity bug report out of old habit since Havoc doesn't read libwnck bugmail
but does read metacity bugmail (see bug 136581, comment 5 and comment 6).  Sorry
about that...
Comment 3 Vincent Untz 2005-02-21 07:49:03 UTC 
Comment on attachment 37728 [details] [review]
Use event->time to pass to wnck_workspace_activate

Thanks Elijah
Comment 4 Elijah Newren 2005-02-21 08:22:40 UTC 
Oh, I forgot.  We need to update the libwnck dependency too.  I'll attach a
patch in a minute that I'll go ahead and commit with the above patch...
Comment 5 Elijah Newren 2005-02-21 08:23:31 UTC 
Created attachment 37736 [details] [review]
Update configure.in to depend on libwnck 2.9.92