After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167965 - Broken check in _gdk_x11_have_render_with_trapezoids
Broken check in _gdk_x11_have_render_with_trapezoids
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.6.x
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-02-20 18:10 UTC by Billy Biggs
Modified: 2005-02-21 04:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Billy Biggs 2005-02-20 18:10:56 UTC 
GTK+ 2.6.2

_gdk_x11_have_render_with_trapezoids checks to see if the variable is GDK_YES,
however if you do have a capable RENDER version, the variable is never set. 
This means that the fallback code is always used, a serious performance hit.

diff -ur gtk+-2.6.2.orig/gdk/x11/gdkdrawable-x11.c
gtk+-2.6.2/gdk/x11/gdkdrawable-x11.c
--- gtk+-2.6.2.orig/gdk/x11/gdkdrawable-x11.c   2005-01-18 16:48:45.000000000 -0500
+++ gtk+-2.6.2/gdk/x11/gdkdrawable-x11.c        2005-02-20 12:59:44.000000000 -0500
@@ -342,11 +342,15 @@
 #define XRENDER_TETRAPEZOIDS_MINOR 4

          if (XRenderQueryVersion (xdisplay, &major_version,
-                                  &minor_version))
+                                  &minor_version)) {
            if ((major_version < XRENDER_TETRAPEZOIDS_MAJOR) ||
                ((major_version == XRENDER_TETRAPEZOIDS_MAJOR) &&
-                  (minor_version < XRENDER_TETRAPEZOIDS_MINOR)))
+                  (minor_version < XRENDER_TETRAPEZOIDS_MINOR))) {
              x11display->have_render_with_trapezoids = GDK_NO;
+            } else {
+             x11display->have_render_with_trapezoids = GDK_YES;
+            }
+          }
        }
     }
Comment 1 Matthias Clasen 2005-02-21 04:12:23 UTC 
2005-02-20  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkdrawable-x11.c (_gdk_x11_have_render_with_trapezoids): 
	Set have_render_with_trapezoids to GDK_YES when we have 
	a new enough Render extension.  (#167965,Billy Biggs)