GNOME Bugzilla – Bug 167899
Next Compilation Error
Last modified: 2005-02-21 08:37:03 UTC
Version details: CVS 2005/02/19 13:21 America/New_York Distribution/Version: Fedora Development Ok, first error fixed, now I get this: if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I../src -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -DORBIT2=1 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/libgnomeprintui-2.2 -I/usr/include/libgnomeprint-2.2 -Wall -Wunused -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror -DG_LOG_DOMAIN=\"Planner\" -DPREFIX=\""/usr"\" -DSYSCONFDIR=\""/etc"\" -DLIBDIR=\""/usr/lib"\" -DDATADIR=\""/usr/share"\" -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DIMAGEDIR=\""/usr/share/pixmaps/planner"\" -DGLADEDIR=\""/usr/share/planner/glade"\" -DVIEWDIR=\""/usr/lib/planner/views"\" -DPLUGINDIR=\""/usr/lib/planner/plugins"\" -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -m32 -march=i686 -mtune=pentium4 -MT planner-print-dialog.o -MD -MP -MF ".deps/planner-print-dialog.Tpo" \ -c -o planner-print-dialog.o `test -f 'planner-print-dialog.c' || echo './'`planner-print-dialog.c; \ then mv -f ".deps/planner-print-dialog.Tpo" ".deps/planner-print-dialog.Po"; \ else rm -f ".deps/planner-print-dialog.Tpo"; exit 1; \ fi planner-print-dialog.c: In function `planner_print_dialog_save_config': planner-print-dialog.c:141: warning: ignoring return value of `write', declared with attribute warn_unused_result make[2]: *** [planner-print-dialog.o] Error 1 make[2]: Leaving directory `/usr/src/redhat/BUILD/planner-0.12.99.200502191321/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/src/redhat/BUILD/planner-0.12.99.200502191321' make: *** [all] Error 2
That's actually a place where we don't care about the return value. I think you should basically only build with -Werror if you are developing, not if you're only going to use planner. If you are developing, maybe you could write a patch for all the various places you find, I'm sure there are a few more.
I didn't specifically tell it to put -Werror in there, just made an RPM using the SPEC provided in CVS and going from there. If it doesn't build with RPM, many distributions are going to have issues with it.
Well, it builds with warnings as errors when you build from CVS as opposed to building from a tarball (unless you tell it not to). You can manually specify it with --with-compile-warnings=no or yes
it could be interesting to see how many warnings the added return value check in fedora development will generate. If you build with --with-compile-warnings=yes, could get attach the build log here then? That would be great.
OK, I was bored so I fixed this as well. If you find any other like this, please attach a full log so we can fix all in one go.
Seems like that was the only one. Compiled cleanly this time without putting --with-compile-warnings=no
Thanks!